Bug 232518 - [ iOS macOS ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-021.html and flex-aspect-ratio-022.html are failing after reverting r284440, r284397, and r284359
Summary: [ iOS macOS ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/fle...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-29 17:03 PDT by ayumi_kojima
Modified: 2022-04-15 02:50 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ayumi_kojima 2021-10-29 17:03:13 PDT 
imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-021.html
imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-022.html

Are failing constantly on all platforms.

History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-sizing%2Faspect-ratio%2Fflex-aspect-ratio-021.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-sizing%2Faspect-ratio%2Fflex-aspect-ratio-022.html

Result page: https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r285053%20(6253)/results.html

According to the history, it started somewhere between r285046 and r285038.

r284440, r284397, and r284359 were revered in https://trac.webkit.org/changeset/285045/webkit. It looks like the failures started in this revision.

I will mark test expectations for these two tests while investigating.
Comment 1 Radar WebKit Bug Importer 2021-10-29 17:05:16 PDT 
<rdar://problem/84828819>
Comment 2 ayumi_kojima 2021-10-29 17:10:06 PDT 
Marked expectations https://trac.webkit.org/changeset/285063/webkit
Comment 3 Sergio Villar Senin 2021-11-03 02:28:35 PDT 
Right, I think Rob landed a patch related to aspect ratio which had a dependency with the refactoring. Cc'ing him
Comment 4 Rob Buis 2021-11-03 02:33:33 PDT 
(In reply to Sergio Villar Senin from comment #3)
> Right, I think Rob landed a patch related to aspect ratio which had a
> dependency with the refactoring. Cc'ing him

Correct, that was https://bugs.webkit.org/show_bug.cgi?id=231947.
Comment 5 Rob Buis 2022-04-15 02:50:38 PDT 
No longer marked as failure since r245397.