Bug 220965 - Fix logic error in shouldComputeLogicalHeightFromAspectRatio
Summary: Fix logic error in shouldComputeLogicalHeightFromAspectRatio
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks: 47738
  Show dependency tree / graph
 
Reported: 2021-01-26 01:13 PST by Rob Buis
Modified: 2021-01-29 00:06 PST (History)
10 users (show)

See Also:

Attachments
Patch (4.28 KB, patch)
2021-01-26 01:34 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (4.18 KB, patch)
2021-01-26 12:35 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (4.11 KB, patch)
2021-01-26 13:54 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2021-01-26 01:13:50 PST 
Fix logic error in shouldComputeLogicalHeightFromAspectRatio.
Comment 1 Rob Buis 2021-01-26 01:34:21 PST 
Created attachment 418380 [details]
Patch
Comment 2 EWS Watchlist 2021-01-26 01:35:06 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Rob Buis 2021-01-26 12:35:58 PST 
Created attachment 418463 [details]
Patch
Comment 4 Rob Buis 2021-01-26 13:54:13 PST 
Created attachment 418474 [details]
Patch
Comment 5 Darin Adler 2021-01-28 13:40:29 PST 
Comment on attachment 418474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418474&action=review

> LayoutTests/TestExpectations:4452
> +webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-007.html [ ImageOnlyFailure ]

No mention of this in the change log. Is this newly failing? Why?
Comment 6 Rob Buis 2021-01-28 23:47:59 PST 
Comment on attachment 418474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418474&action=review

>> LayoutTests/TestExpectations:4452
>> +webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-007.html [ ImageOnlyFailure ]
> 
> No mention of this in the change log. Is this newly failing? Why?

I am not sure yet. I expect to eventually address it with https://bugs.webkit.org/show_bug.cgi?id=220861.
Comment 7 EWS 2021-01-29 00:05:00 PST 
Committed r272049: <https://trac.webkit.org/changeset/272049>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418474 [details].
Comment 8 Radar WebKit Bug Importer 2021-01-29 00:06:14 PST 
<rdar://problem/73743737>