Bug 220861 - Support aspect-ratio in intrinsic sizing
Summary: Support aspect-ratio in intrinsic sizing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks: 47738
  Show dependency tree / graph
 
Reported: 2021-01-22 08:36 PST by Rob Buis
Modified: 2021-03-08 04:37 PST (History)
8 users (show)

See Also:

Attachments
Patch (8.08 KB, patch)
2021-01-22 08:39 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (8.21 KB, patch)
2021-01-28 02:50 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (11.31 KB, patch)
2021-02-06 02:59 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (11.36 KB, patch)
2021-02-18 06:22 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (12.69 KB, patch)
2021-02-18 08:34 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (13.55 KB, patch)
2021-02-19 02:10 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (13.57 KB, patch)
2021-02-21 03:22 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (14.41 KB, patch)
2021-02-21 12:56 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (14.84 KB, patch)
2021-02-22 10:31 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (14.96 KB, patch)
2021-02-22 12:50 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (15.22 KB, patch)
2021-02-24 03:39 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (15.58 KB, patch)
2021-02-27 04:54 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (13.03 KB, patch)
2021-02-27 10:44 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (12.35 KB, patch)
2021-02-27 12:56 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (12.37 KB, patch)
2021-02-28 13:01 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (12.37 KB, patch)
2021-03-03 02:52 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (13.02 KB, patch)
2021-03-07 08:02 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (13.21 KB, patch)
2021-03-08 03:02 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (17) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2021-01-22 08:36:53 PST 
Support aspect-ratio in intrinsic sizing.
Comment 1 Rob Buis 2021-01-22 08:39:32 PST 
Created attachment 418150 [details]
Patch
Comment 2 Rob Buis 2021-01-28 02:50:50 PST 
Created attachment 418632 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2021-01-29 08:37:14 PST 
<rdar://problem/73755568>
Comment 4 Rob Buis 2021-02-06 02:59:19 PST 
Created attachment 419498 [details]
Patch
Comment 5 Rob Buis 2021-02-18 06:22:53 PST 
Created attachment 420826 [details]
Patch
Comment 6 Rob Buis 2021-02-18 08:34:20 PST 
Created attachment 420831 [details]
Patch
Comment 7 Rob Buis 2021-02-19 02:10:16 PST 
Created attachment 420944 [details]
Patch
Comment 8 Rob Buis 2021-02-21 03:22:35 PST 
Created attachment 421135 [details]
Patch
Comment 9 Rob Buis 2021-02-21 12:56:53 PST 
Created attachment 421148 [details]
Patch
Comment 10 Rob Buis 2021-02-22 10:31:45 PST 
Created attachment 421210 [details]
Patch
Comment 11 Rob Buis 2021-02-22 12:50:27 PST 
Created attachment 421228 [details]
Patch
Comment 12 Rob Buis 2021-02-24 03:39:12 PST 
Created attachment 421393 [details]
Patch
Comment 13 Rob Buis 2021-02-27 04:54:48 PST 
Created attachment 421744 [details]
Patch
Comment 14 Rob Buis 2021-02-27 10:44:28 PST 
Created attachment 421751 [details]
Patch
Comment 15 Rob Buis 2021-02-27 12:56:48 PST 
Created attachment 421754 [details]
Patch
Comment 16 Rob Buis 2021-02-28 13:01:41 PST 
Created attachment 421779 [details]
Patch
Comment 17 Rob Buis 2021-03-03 02:52:06 PST 
Created attachment 422053 [details]
Patch
Comment 18 Rob Buis 2021-03-07 08:02:02 PST 
Created attachment 422528 [details]
Patch
Comment 19 Antti Koivisto 2021-03-08 01:38:31 PST 
Comment on attachment 422528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422528&action=review

> Source/WebCore/rendering/RenderBox.h:88
> +    LayoutUnit constrainLogicalWidthInFragmentByMinMax(LayoutUnit, LayoutUnit, RenderBlock&, RenderFragmentContainer*, bool allowIntrinsic = true) const;

Please use an enum. The 'false' in call site is mysterious.
Comment 20 Rob Buis 2021-03-08 03:02:48 PST 
Created attachment 422552 [details]
Patch
Comment 21 EWS 2021-03-08 04:37:51 PST 
Committed r274068: <https://commits.webkit.org/r274068>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422552 [details].