Bug 220928 - 2 WPT tests in css/css-color/predefined-*.html failing (was 14)
Summary: 2 WPT tests in css/css-color/predefined-*.html failing (was 14)
Status: RESOLVED DUPLICATE of bug 225438
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 220940 221018 221114 221116 221190 222235
Blocks:
  Show dependency tree / graph
 
Reported: 2021-01-25 08:55 PST by Sam Weinig
Modified: 2021-05-06 01:20 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-01-25 08:55:59 PST 
Many of the WPT tests matching css/css-color/predefined-*.html are failing in WebKit. The complete set that fail are:

imported/w3c/web-platform-tests/css/css-color/predefined-002.html
imported/w3c/web-platform-tests/css/css-color/predefined-003.html
imported/w3c/web-platform-tests/css/css-color/predefined-004.html
imported/w3c/web-platform-tests/css/css-color/predefined-006.html
imported/w3c/web-platform-tests/css/css-color/predefined-007.html
imported/w3c/web-platform-tests/css/css-color/predefined-008.html
imported/w3c/web-platform-tests/css/css-color/predefined-009.html
imported/w3c/web-platform-tests/css/css-color/predefined-010.html
imported/w3c/web-platform-tests/css/css-color/predefined-011.html
imported/w3c/web-platform-tests/css/css-color/predefined-012.html
imported/w3c/web-platform-tests/css/css-color/predefined-014.html
imported/w3c/web-platform-tests/css/css-color/predefined-015.html
imported/w3c/web-platform-tests/css/css-color/predefined-016.html
imported/w3c/web-platform-tests/css/css-color/predefined-017.html
Comment 1 Darin Adler 2021-01-25 10:23:37 PST 
Interested to learn what kind of failures these are. User-visible failures of some kind? Subtle failures where the tests *require* rounding color values to lower precision? Watching this space.
Comment 2 Sam Weinig 2021-01-25 13:01:46 PST 
Fixing a few in 220940.
Comment 3 Darin Adler 2021-01-25 15:36:29 PST 
We could have titled this bug "14 tests failing" rather than "many tests failing".
Comment 4 Darin Adler 2021-01-25 15:37:07 PST 
And after bug 220940, down to 11.
Comment 5 Darin Adler 2021-01-25 15:40:14 PST 
Could use that style people sometimes use in bugs inside Apple: "11 tests failing (was 14)".
Comment 6 Sam Weinig 2021-01-28 13:20:06 PST 
And after bug 221018, down to 9.
Comment 7 Sam Weinig 2021-01-31 10:00:37 PST 
And after bug 221114, down to 7.
Comment 8 Sam Weinig 2021-01-31 10:02:04 PST 
(In reply to Sam Weinig from comment #7)
> And after bug 221114, down to 7.

Actually, it is down to 8.
Comment 9 Sam Weinig 2021-01-31 10:03:36 PST 
(When Darin wrote "down to 11", it was actually 12, and I have been miscounting since then :) ).
Comment 10 Sam Weinig 2021-01-31 16:18:00 PST 
And after bug 221116, down to 6.
Comment 11 Radar WebKit Bug Importer 2021-02-01 08:56:13 PST 
<rdar://problem/73830969>
Comment 12 Sam Weinig 2021-02-03 11:55:34 PST 
After bug 221190, down to 5.
Comment 13 Sam Weinig 2021-02-22 16:57:46 PST 
After bug 222235, down to 2.
Comment 14 Sam Weinig 2021-03-06 11:48:11 PST 
The final 2 will likely be removed from the test suite as fallback seems likely to be removed from the spec - https://github.com/w3c/csswg-drafts/issues/5931.

Either way, holding off on implementing fallback until that is resolved.
Comment 15 Tim Nguyen (:ntim) 2021-05-06 01:20:16 PDT 

*** This bug has been marked as a duplicate of bug 225438 ***