Bug 221018 – Add support for color(a98-rgb ...) as part of CSS Color 4

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Sam Weinig]

Add support for Adobe RGB 1998 and color(a98-rgb ...) as part of CSS Color 4 - https://www.w3.org/TR/css-color-4/#valdef-color-a98-rgb.

[Sam Weinig]

Created attachment 418486 [details]
Patch

[Sam Weinig]

Created attachment 418490 [details]
Patch

[Darin Adler]

Looked over the patch and it sure does look good. Wonder how this slightly changed the P3 results?

[Sam Weinig]

(In reply to Darin Adler from comment #3)
> Looked over the patch and it sure does look good. Wonder how this slightly
> changed the P3 results?

I swapped the matrix values between the p3 and a98-rgb conversion matrices :(. Classic copy and paste-o for me. I'm adding a few more tests and will re-upload with the fix.

[Sam Weinig]

Created attachment 418564 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Darin Adler]

Comment on attachment 418564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418564&action=review

> Source/WebCore/platform/graphics/ColorConversion.h:204
> +        return std::invoke(std::forward<Functor>(functor), makeFromComponents<SRGBA<T>>(components));

Wondering how to refine further to make the per-encoding as small as possible. Like, can the std::invoke be shared without hurting efficiency?

Really makes me wonder about the fundamental question: Practical way to map a runtime enumeration to a template name.

> Source/WebCore/platform/graphics/ColorTypes.h:34
> +template<typename> struct SRGBA;

I’m a big fan of alphabetizing such things rather than putting them in logical order. Would include AlphaTraits too.

[EWS]

Committed r271992: <https://trac.webkit.org/changeset/271992>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418564 [details].

[Radar WebKit Bug Importer]

<rdar://problem/73687600>