Bug 220582 – Handle min-width/min-height:auto for aspect-ratio

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rob Buis]

Handle min-width/min-height:auto for aspect-ratio.

[Rob Buis]

Created attachment 417516 [details]
Patch

[Rob Buis]

Created attachment 417781 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/73395736>

[Rob Buis]

Created attachment 417968 [details]
Patch

[Rob Buis]

Created attachment 417992 [details]
Patch

[Rob Buis]

Created attachment 418541 [details]
Patch

[Rob Buis]

Created attachment 419265 [details]
Patch

[Rob Buis]

Created attachment 419685 [details]
Patch

[Antti Koivisto]

Comment on attachment 419685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419685&action=review

> Source/WebCore/rendering/RenderBox.cpp:665
> +    Length minLength = styleToUse.logicalMinWidth();

could use auto

> Source/WebCore/rendering/RenderBox.cpp:3810
> +    if (widthType == MinSize && logicalWidth.isAuto()) {
> +        if (shouldComputeLogicalWidthFromAspectRatio()) {
> +            LayoutUnit minLogicalWidth;
> +            LayoutUnit maxLogicalWidth;
> +            computeIntrinsicLogicalWidths(minLogicalWidth, maxLogicalWidth);
> +            logicalWidth = Length(minLogicalWidth, Fixed);
> +        } else
> +            logicalWidth = Length(0, Fixed);
> +    } else if (widthType == MainOrPreferredSize && logicalWidth.isAuto() && shouldComputeLogicalWidthFromAspectRatio())
>          logicalWidth = Length(computeLogicalWidthFromAspectRatio(), Fixed);
>      else if (logicalWidth.isIntrinsic())
>          logicalWidth = Length(computeIntrinsicLogicalWidthUsing(logicalWidth, containerLogicalWidth, bordersPlusPadding) - bordersPlusPadding, Fixed);

This sort of code can often made read better by using lambdas and early returns.

[Antti Koivisto]

Comment on attachment 419685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419685&action=review

> LayoutTests/TestExpectations:4421
> +webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-008.html [ ImageOnlyFailure ]

Why does this break?

[Rob Buis]

Comment on attachment 419685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419685&action=review

>> LayoutTests/TestExpectations:4421
>> +webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-008.html [ ImageOnlyFailure ]
> 
> Why does this break?

Flex support still needs to land:
https://bugs.webkit.org/show_bug.cgi?id=219679
I am waiting on an Igalia colleague for some flexbox fixes so that patch can be rebased and made smaller.

[Rob Buis]

Created attachment 419966 [details]
Patch

[EWS]

Committed r272718: <https://commits.webkit.org/r272718>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419966 [details].