Bug 218811 – Terminate WebProcesses if GPUProcess crashes more than twice in 30 seconds

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Terminate WebProcesses if GPUProcess crashes more than twice in 30 seconds.

[Radar WebKit Bug Importer]

<rdar://problem/71292424>

[Chris Dumez]

Created attachment 413856 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 413856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413856&action=review

> Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:111
> +    RELEASE_LOG_ERROR(Process, "AuxiliaryProcessProxy::terminate");

Can this log the pid of the thing being terminated?

[Chris Dumez]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 413856 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413856&action=review
> 
> > Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:111
> > +    RELEASE_LOG_ERROR(Process, "AuxiliaryProcessProxy::terminate");
> 
> Can this log the pid of the thing being terminated?

good idea. Will fix.

[Chris Dumez]

Created attachment 413858 [details]
Patch

[Geoffrey Garen]

Comment on attachment 413858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413858&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:270
> +#if ENABLE(GPU_PROCESS)
> +    , m_resetGPUProcessCrashCountTimer(RunLoop::main(), this, &WebProcessPool::resetGPUProcessCrashCount)
> +#endif

DeferrableTaskTimer is slightly nicer for this kind of thing because it doesn't require an initializer.

> Source/WebKit/UIProcess/WebProcessPool.cpp:519
> +void WebProcessPool::resetGPUProcessCrashCount()
> +{
> +    m_recentGPUProcessCrashCount = 0;
>  }

DeferrableTaskTimer is slightly nicer for this kind of thing because it doesn't require a separate function.

[EWS]

Committed r269703: <https://trac.webkit.org/changeset/269703>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413858 [details].

[Chris Dumez]

(In reply to Geoffrey Garen from comment #6)
> Comment on attachment 413858 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413858&action=review
> 
> > Source/WebKit/UIProcess/WebProcessPool.cpp:270
> > +#if ENABLE(GPU_PROCESS)
> > +    , m_resetGPUProcessCrashCountTimer(RunLoop::main(), this, &WebProcessPool::resetGPUProcessCrashCount)
> > +#endif
> 
> DeferrableTaskTimer is slightly nicer for this kind of thing because it
> doesn't require an initializer.
> 
> > Source/WebKit/UIProcess/WebProcessPool.cpp:519
> > +void WebProcessPool::resetGPUProcessCrashCount()
> > +{
> > +    m_recentGPUProcessCrashCount = 0;
> >  }
> 
> DeferrableTaskTimer is slightly nicer for this kind of thing because it
> doesn't require a separate function.

Following up in https://bugs.webkit.org/show_bug.cgi?id=218828.