Bug 218806 - [GPUProcess] Seamlessly resume WebAudio playback if the GPU Process crashes
Summary: [GPUProcess] Seamlessly resume WebAudio playback if the GPU Process crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 218811
  Show dependency tree / graph
 
Reported: 2020-11-11 09:12 PST by Chris Dumez
Modified: 2020-11-11 12:18 PST (History)
14 users (show)

See Also:

Attachments
Patch (15.61 KB, patch)
2020-11-11 09:16 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (16.74 KB, patch)
2020-11-11 10:19 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (17.15 KB, patch)
2020-11-11 10:33 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-11-11 09:12:23 PST 
If the GPU Process crashes during WebAudio playback, the GPU Process should get relaunched and WebAudio playback should seamlessly continue.
Comment 1 Chris Dumez 2020-11-11 09:16:35 PST 
Created attachment 413827 [details]
Patch
Comment 2 Chris Dumez 2020-11-11 10:19:42 PST 
Created attachment 413836 [details]
Patch
Comment 3 Chris Dumez 2020-11-11 10:33:33 PST 
Created attachment 413838 [details]
Patch
Comment 4 Peng Liu 2020-11-11 11:15:17 PST 
Comment on attachment 413838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413838&action=review

> Source/WebKit/ChangeLog:12
> +        audio rendering will seamlessly continue.

Very nice!
Comment 5 Geoffrey Garen 2020-11-11 11:49:28 PST 
Comment on attachment 413838 [details]
Patch

r=me
Comment 6 EWS 2020-11-11 12:17:15 PST 
Committed r269698: <https://trac.webkit.org/changeset/269698>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413838 [details].
Comment 7 Radar WebKit Bug Importer 2020-11-11 12:18:18 PST 
<rdar://problem/71293817>