Bug 219719 - [iOS] TestWebKitAPI.GPUProcess.WebProcessTerminationAfterTooManyGPUProcessCrashes is a flaky failure
Summary: [iOS] TestWebKitAPI.GPUProcess.WebProcessTerminationAfterTooManyGPUProcessCra...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-09 16:30 PST by Ryan Haddad
Modified: 2020-12-10 09:17 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.21 KB, patch)
2020-12-09 16:44 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.62 KB, patch)
2020-12-09 17:42 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2020-12-09 16:30:12 PST 
The following test is a flaky failure on iOS release bots:

    TestWebKitAPI.GPUProcess.WebProcessTerminationAfterTooManyGPUProcessCrashes
        ERROR: AudioOutputUnitStart() call failed with error code: -10851
        
        /Volumes/Data/slave/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:198
        Value of: [webView _isPlayingAudio]
          Actual: false
        Expected: true

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.GPUProcess.WebProcessTerminationAfterTooManyGPUProcessCrashes
Comment 1 Ryan Haddad 2020-12-09 16:31:03 PST 
The test was added with https://trac.webkit.org/changeset/269703/webkit
Comment 2 Radar WebKit Bug Importer 2020-12-09 16:31:27 PST 
<rdar://problem/72158303>
Comment 3 Chris Dumez 2020-12-09 16:44:15 PST 
Created attachment 415812 [details]
Patch
Comment 4 Darin Adler 2020-12-09 17:05:04 PST 
Comment on attachment 415812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415812&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:218
> +    // FIXME: In the iOS simulator, video resumes after the GPU process crash but audio does not.

Comment says simulator, conditional just says iOS.
Comment 5 Chris Dumez 2020-12-09 17:41:15 PST 
(In reply to Darin Adler from comment #4)
> Comment on attachment 415812 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=415812&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:218
> > +    // FIXME: In the iOS simulator, video resumes after the GPU process crash but audio does not.
> 
> Comment says simulator, conditional just says iOS.

Will fix. The issue reproduces on both simulator and device. We just don't run API tests on device AFAIK.
Comment 6 Chris Dumez 2020-12-09 17:42:49 PST 
Created attachment 415816 [details]
Patch
Comment 7 EWS 2020-12-10 09:17:05 PST 
Committed r270628: <https://trac.webkit.org/changeset/270628>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415816 [details].