Bug 218706 - [build.webkit.org] Add python 3 support - part 3
Summary: [build.webkit.org] Add python 3 support - part 3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency treegraph
 
Reported: 2020-11-09 06:35 PST by Aakash Jain
Modified: 2021-02-08 07:37 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.63 KB, patch)
2020-11-09 06:45 PST, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (6.67 KB, patch)
2020-11-09 06:49 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-11-09 06:35:43 PST
Python 3 support is required for Buildbot 2+.

Part 1 and 2 of this change were in: https://bugs.webkit.org/show_bug.cgi?id=217727 and https://bugs.webkit.org/show_bug.cgi?id=218130
Comment 1 Aakash Jain 2020-11-09 06:45:14 PST
Created attachment 413581 [details]
Patch
Comment 2 Aakash Jain 2020-11-09 06:49:40 PST
Created attachment 413582 [details]
Patch
Comment 3 Jonathan Bedard 2020-11-09 08:30:35 PST
Comment on attachment 413582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413582&action=review

> Tools/CISupport/build-webkit-org/loadConfig.py:-189
> -    keywords = filter(None, re.split('[, \-_:()]+', str(builder['name'])))

Seems like code that results in the what the original code is would be:

keywords = re.split('[, \-_:()]+', str(builder['name'])) or None

But it likely doesn't matter.
Comment 4 EWS 2020-11-09 08:41:42 PST
Committed r269581: <https://trac.webkit.org/changeset/269581>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413582 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-09 08:42:20 PST
<rdar://problem/71193363>