Bug 217727 - [build.webkit.org] Add python 3 support - part 1
Summary: [build.webkit.org] Add python 3 support - part 1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency treegraph
 
Reported: 2020-10-14 13:04 PDT by Aakash Jain
Modified: 2021-02-08 07:37 PST (History)
5 users (show)

See Also:


Attachments
Patch (10.55 KB, patch)
2020-10-14 13:12 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-10-14 13:04:40 PDT
[build.webkit.org] Add python 3 support. Python 3 support is required for Buildbot 2+.
Comment 1 Aakash Jain 2020-10-14 13:12:54 PDT
Created attachment 411367 [details]
Patch
Comment 2 Jonathan Bedard 2020-10-14 15:08:24 PDT
Comment on attachment 411367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411367&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:-5
> -import StringIO

I assume we aren't using StringIO here, but if we find we need it, webkitcorepy has that standardized for code that needs to be both Python 2 and 3.
Comment 3 EWS 2020-10-14 16:08:20 PDT
Committed r268496: <https://trac.webkit.org/changeset/268496>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411367 [details].
Comment 4 Radar WebKit Bug Importer 2020-10-14 16:09:40 PDT
<rdar://problem/70312366>