Bug 218123 - Rename slave to worker in webkitpy
Summary: Rename slave to worker in webkitpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 213092
  Show dependency treegraph
 
Reported: 2020-10-23 07:29 PDT by Aakash Jain
Modified: 2021-05-17 10:01 PDT (History)
5 users (show)

See Also:


Attachments
Patch (14.71 KB, patch)
2020-10-23 07:58 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-10-23 07:29:12 PDT
Rename slave to worker in webkitpy. This is to use more inclusive naming.
Comment 1 Aakash Jain 2020-10-23 07:58:57 PDT
Created attachment 412177 [details]
Patch
Comment 2 Jonathan Bedard 2020-10-23 09:08:16 PDT
Comment on attachment 412177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412177&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:578
> +        build_worker = self._options.build_slave

We will need to expose a "build_worker" option, change all our buildbot invocations, and then remove the "build_slave" option to totally get rid of this. (not particularly difficult, just going to take a few patches and a few buildbot restarts)
Comment 3 Aakash Jain 2020-10-23 09:10:38 PDT
Yeah.
Comment 4 EWS 2020-10-23 09:13:33 PDT
Committed r268925: <https://trac.webkit.org/changeset/268925>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412177 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-23 09:14:22 PDT
<rdar://problem/70621688>