Bug 218042 - [WPE] Build error with ENABLE_VIDEO=OFF
Summary: [WPE] Build error with ENABLE_VIDEO=OFF
Status: RESOLVED DUPLICATE of bug 232264
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2020-10-21 11:53 PDT by Bastian Krause
Modified: 2021-10-25 14:29 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bastian Krause 2020-10-21 11:53:40 PDT 
Various errors occur when building the WPE port via:

$ cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja -DCMAKE_BUILD_TYPE=Release -DANALYZERS=OFF -DDEBUG_FISSION=OFF -DENABLE_ACCELERATED_2D_CANVAS=OFF -DENABLE_ACCESSIBILITY=OFF -DENABLE_BUBBLEWRAP_SANDBOX=OFF -DENABLE_ENCRYPTED_MEDIA=OFF -DENABLE_GTKDOC=OFF -DENABLE_MEDIA_SOURCE=OFF -DENABLE_SHAREABLE_RESOURCE=ON -DENABLE_VIDEO=OFF -DENABLE_WEBDRIVER=ON -DENABLE_WEB_AUDIO=OFF -DENABLE_WEB_CRYPTO=ON -DENABLE_WPE_QT_API=OFF -DENABLE_XSLT=ON -DGCC_OFFLINEASM_SOURCE_MAP=OFF -DSHOULD_INSTALL_JS_SHELL=OFF -DSHOW_BINDINGS_GENERATION_PROGRESS=ON -DUSE_LD_GOLD=OFF -DUSE_OPENJPEG=OFF -DUSE_SYSTEMD=OFF -DUSE_THIN_ARCHIVES=ON -DUSE_WOFF2=OFF -DWTF_CPU_ARM64_CORTEXA53=OFF
$ ninja

Source/WebCore/editing/markup.cpp: In function ‘std::unique_ptr<WebCore::Page> WebCore::createPageForSanitizingWebContent()’:
Source/WebCore/editing/markup.cpp:181:22: error: ‘class WebCore::Settings’ has no member named ‘setMediaEnabled’; did you mean ‘setJavaEnabled’?
     page->settings().setMediaEnabled(false);
                      ^~~~~~~~~~~~~~~
                      setJavaEnabled

Source/WebCore/platform/graphics/GraphicsContext.cpp:1283:5: error: invalid use of incomplete type ‘class WebCore::MediaPlayer’
     player.playerPrivate()->paintCurrentFrameInContext(*this, destination);

Source/WebCore/page/Page.cpp:2049:23: error: ‘class WebCore::ChromeClient’ has no member named ‘playbackControlsMediaEngineChanged’
     chrome().client().playbackControlsMediaEngineChanged();

Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:1260:20: error: invalid use of incomplete type ‘class WebCore::MediaPlayer’
     , m_identifier(player.identifier())


I guess most of them can be fixed with #if ENABLE(VIDEO) ... #endif.
Comment 1 Pablo Saavedra 2020-11-13 11:15:21 PST 
I can reproduce the issue too.
Comment 2 Adrian Perez 2021-10-25 14:29:20 PDT 
Thanks for reporting!

I am doing a round of fixes for ENABLE_VIDEO=OFF in bug #232264
both for the GTK and WPE ports — let's mark this bug as duplicate.

*** This bug has been marked as a duplicate of bug 232264 ***