Bug 232264 – Multiple build issues with ENABLE_VIDEO=OFF

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adrian Perez]

In particular, at least AXObjectCache.cpp and BifurcatedGraphicsContext.cpp
are using HTMLMediaElement without guarding their usage with ENABLE(VIDEO).
The issue on the latter affects also the 2.34.x releases.

Also, the recently landed support for media session (see bug #217991) needs
to be gated on ENABLE_VIDEO.

[Adrian Perez]

Created attachment 442408 [details]
Patch

[Adrian Perez]

Created attachment 442415 [details]
Patch

[Adrian Perez]

*** Bug 232199 has been marked as a duplicate of this bug. ***

[Adrian Perez]

*** Bug 218042 has been marked as a duplicate of this bug. ***

[Carlos Garcia Campos]

Comment on attachment 442415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442415&action=review

> Source/WebCore/ChangeLog:3
> +        [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF

This is not specific to WPE/GTK, all the changes are in cross-platform code.

[Adrian Perez]

(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 442415 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442415&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF
> 
> This is not specific to WPE/GTK, all the changes are in cross-platform code.

Right. At first I thought this was WPE/GTK specific, when filing the bug.
I'll change the title before landing 👍️

[Adrian Perez]

Created attachment 442468 [details]
Patch for landing

[EWS]

Committed r284858 (243535@main): <https://commits.webkit.org/243535@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442468 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84651607>

[sL1pKn07]

seems still occour in 2.34.3. see https://bugs.webkit.org/show_bug.cgi?id=232394#c4

greetings