Bug 225310 – [Stable][WPE] 2.32 build Error with ENABLE_VIDEO=OFF/ENABLE_VIDEO_TRACK=OFF

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Bastian Krause]

I'm building wpewebkit 2.32.0 via meta-webkit@4cedcb6 (top of main branch) with

  PACKAGECONFIG_remove = "video"

That means adding

  -DENABLE_VIDEO=OFF -DENABLE_VIDEO_TRACK=OFF

leads to these build failures:

In file included from [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:30,
                 from [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:30:
[...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/wpewebkit-2.32.0/Source/WebCore/platform/graphics/GraphicsContextGL.h:1310:39: error: 'MediaPlayer' has not been declared
 1310 |     virtual bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum format, GCGLenum type, bool premultiplyAlpha, bool flipY) = 0;
      |                                       ^~~~~~~~~~~
In file included from [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:30:
[...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:469:10: error: 'bool WebCore::GraphicsContextGLOpenGL::copyTextureFromMedia(WebCore::MediaPlayer&, PlatformGLObject, GCGLenum, GCGLint, GCGLenum, GCGLenum, GCGLenum, bool, bool)' marked 'final', but is not virtual
  469 |     bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum format, GCGLenum type, bool premultiplyAlpha, bool flipY) final;
      |          ^~~~~~~~~~~~~~~~~~~~

[Philippe Normand]

The ENABLE_VIDEO_TRACK CMake option was removed BTW. It is implied by VIDEO now.

[Philippe Normand]

This code was heavily updated in ToT. I don't see how the VIDEO=OFF build would fail there. Someone will need to fix this specific issue in the stable branch.

[Adrian Perez]

(In reply to Philippe Normand from comment #2)
> This code was heavily updated in ToT. I don't see how the VIDEO=OFF build
> would fail there. Someone will need to fix this specific issue in the stable
> branch.

Backporting the fix from bug #225316 to the 2.32 release branch fixes
the build with ENABLE_VIDEO=OFF.

[Philippe Normand]

(In reply to Bastian Krause from comment #0)
> I'm building wpewebkit 2.32.0 via meta-webkit@4cedcb6 (top of main branch)
> with
> 
>   PACKAGECONFIG_remove = "video"
> 
> That means adding
> 
>   -DENABLE_VIDEO=OFF -DENABLE_VIDEO_TRACK=OFF
> 
> leads to these build failures:
> 
> In file included from
> [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/
> GraphicsContextGLOpenGL.h:30,
>                  from
> [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/
> GraphicsContextGLOpenGLCommon.cpp:30:
> [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> wpewebkit-2.32.0/Source/WebCore/platform/graphics/GraphicsContextGL.h:1310:
> 39: error: 'MediaPlayer' has not been declared
>  1310 |     virtual bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject
> texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum
> format, GCGLenum type, bool premultiplyAlpha, bool flipY) = 0;
>       |                                       ^~~~~~~~~~~
> In file included from
> [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/
> GraphicsContextGLOpenGLCommon.cpp:30:
> [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/
> GraphicsContextGLOpenGL.h:469:10: error: 'bool
> WebCore::GraphicsContextGLOpenGL::copyTextureFromMedia(WebCore::MediaPlayer&,
> PlatformGLObject, GCGLenum, GCGLint, GCGLenum, GCGLenum, GCGLenum, bool,
> bool)' marked 'final', but is not virtual
>   469 |     bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject
> texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum
> format, GCGLenum type, bool premultiplyAlpha, bool flipY) final;
>       |          ^~~~~~~~~~~~~~~~~~~~

But bug 225316 doesn't fix any of that ^^^
I'm confused now :)

[Adrian Perez]

(In reply to Philippe Normand from comment #4)
> (In reply to Bastian Krause from comment #0)
> > I'm building wpewebkit 2.32.0 via meta-webkit@4cedcb6 (top of main branch)
> > with
> > 
> >   PACKAGECONFIG_remove = "video"
> > 
> > That means adding
> > 
> >   -DENABLE_VIDEO=OFF -DENABLE_VIDEO_TRACK=OFF
> > 
> > leads to these build failures:
> > 
> > In file included from
> > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> > wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/
> > GraphicsContextGLOpenGL.h:30,
> >                  from
> > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> > wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/
> > GraphicsContextGLOpenGLCommon.cpp:30:
> > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> > wpewebkit-2.32.0/Source/WebCore/platform/graphics/GraphicsContextGL.h:1310:
> > 39: error: 'MediaPlayer' has not been declared
> >  1310 |     virtual bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject
> > texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum
> > format, GCGLenum type, bool premultiplyAlpha, bool flipY) = 0;
> >       |                                       ^~~~~~~~~~~
> > In file included from
> > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> > wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/
> > GraphicsContextGLOpenGLCommon.cpp:30:
> > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> > wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/
> > GraphicsContextGLOpenGL.h:469:10: error: 'bool
> > WebCore::GraphicsContextGLOpenGL::copyTextureFromMedia(WebCore::MediaPlayer&,
> > PlatformGLObject, GCGLenum, GCGLint, GCGLenum, GCGLenum, GCGLenum, bool,
> > bool)' marked 'final', but is not virtual
> >   469 |     bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject
> > texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum
> > format, GCGLenum type, bool premultiplyAlpha, bool flipY) final;
> >       |          ^~~~~~~~~~~~~~~~~~~~
> 
> But bug 225316 doesn't fix any of that ^^^
> I'm confused now :)

The fix from bug #225316 was definitely needed for ENABLE_VIDEO=OFF,
maybe the reporter has other build options enabled that affect the
outcome. My test build was a clean done with:

  % CC=clang CXX=clang++ cmake -GNinja -DPORT=WPE \
      -DCMAKE_BUILD_TYPE=Release -DENABLE_VIDEO=OFF -S. \
      -Bbuild-wpe 
  % ninja -C build-wpe

In my case I am working on top of the release branch, which *also* has
a backport of the fix for bug #224198 — both are needed.

[Adrian Perez]

(In reply to Adrian Perez from comment #5)

> The fix from bug #225316 was definitely needed for ENABLE_VIDEO=OFF,
>
> […]
> 
> In my case I am working on top of the release branch, which *also* has
> a backport of the fix for bug #224198 — both are needed.

I went ahead and merged the fix from bug #225316 as r276977 in the
release branch; this issue will be gone in 2.32.1 which will be released
later this week :)

[Bastian Krause]

Awesome, thanks!