Use feature flag in build.webkit.org code to support both Buildbot 0.8 as well as Buildbot 2 code. Current code is for Buildbot 0.8. We are planning to update to latest Buildbot (https://bugs.webkit.org/show_bug.cgi?id=175056).
Created attachment 411595 [details] Patch
Tested on uat instance.
Created attachment 411608 [details] Patch
Comment on attachment 411608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411608&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:161 > + builder['category'] = category Weren't we setting the category before? This seems like a change in behavior for the current buildbot.
Comment on attachment 411608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411608&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:161 >> + builder['category'] = category > > Weren't we setting the category before? This seems like a change in behavior for the current buildbot. We were setting builder['category'] before as well. Now we are setting the 'category' variable and later assigning it to builder['category'], but only for old-buildbot-version. There shouldn't be any change in behavior for current buildbot (0.8.6p1). For new Buildbot version we will be using tags (in subsequent patch). As per http://docs.buildbot.net/latest/relnotes/0.9.0.html#changes-and-removals "Builders now have “tags” instead of a category. Builders can have multiple tags, allowing more flexible builder displays."
Committed r268674: <https://trac.webkit.org/changeset/268674> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411608 [details].
<rdar://problem/70448398>
(In reply to Aakash Jain from comment #5) > For new Buildbot version we will be using tags (in subsequent patch). Adding tags for new Buildbot version in https://bugs.webkit.org/show_bug.cgi?id=217958