WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
217958
[build.webkit.org] Use builder tags instead of category for latest buildbot
https://bugs.webkit.org/show_bug.cgi?id=217958
Summary
[build.webkit.org] Use builder tags instead of category for latest buildbot
Aakash Jain
Reported
2020-10-20 08:37:46 PDT
We are planning to upgrade build.webkit.org to latest Buildbot. As per
http://docs.buildbot.net/latest/relnotes/0.9.0.html#changes-and-removals
"Builders now have “tags” instead of a category. Builders can have multiple tags, allowing more flexible builder displays." We can generate these tags automatically from builder names and each builder can have multiple tags. This will allow easily filtering builder page using tags. Note that we can keep this code consistent with EWS code, so that eventually we can easily merge both codebases.
Attachments
Patch
(4.80 KB, patch)
2020-10-20 08:40 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Patch
(4.79 KB, patch)
2020-10-20 09:03 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2020-10-20 08:38:05 PDT
<
rdar://problem/35211115
>
Aakash Jain
Comment 2
2020-10-20 08:40:48 PDT
Created
attachment 411868
[details]
Patch
Jonathan Bedard
Comment 3
2020-10-20 08:47:16 PDT
Comment on
attachment 411868
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=411868&action=review
> Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:183 > + tags_blacklist = [str(i) for i in xrange(0, 20)]
Should be blocklist, no?
Aakash Jain
Comment 4
2020-10-20 09:02:47 PDT
Comment on
attachment 411868
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=411868&action=review
>> Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:183 >> + tags_blacklist = [str(i) for i in xrange(0, 20)] > > Should be blocklist, no?
Good catch. Missed this one while making this change in multiple places. Fixed in updated patch.
Aakash Jain
Comment 5
2020-10-20 09:03:28 PDT
Created
attachment 411871
[details]
Patch
EWS
Comment 6
2020-10-20 10:53:59 PDT
Committed
r268749
: <
https://trac.webkit.org/changeset/268749
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 411871
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug