Bug 217434 - [build.webkit.org] Ensure that builder names are valid Buildbot identifiers
Summary: [build.webkit.org] Ensure that builder names are valid Buildbot identifiers
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency treegraph
Reported: 2020-10-07 12:28 PDT by Aakash Jain
Modified: 2021-02-08 07:37 PST (History)
9 users (show)

See Also:

Patch (67.95 KB, patch)
2020-10-07 12:40 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-10-07 12:28:33 PDT
We are planning to upgrade build.webkit.org to latest buildbot. In buildbot 0.9+ builder name is an identifier and can not contain space. 

As per http://docs.buildbot.net/0.9.8/manual/installation/nine-upgrade.html#identifiers :
"An "identifier" is a nonempty unicode string of limited length, containing only ASCII alphanumeric characters along with - (dash) and _ (underscore), and not beginning with a digit."

Many of the builder names already follow this naming conventions, since we have been following this convention while adding new builders. We should rename rest of the builder names as well (to not contain any space and symbols). Note that we wouldn't be able to keep the history of old builders after renaming them. However, the test results should still be available at results.webkit.org
Comment 1 Aakash Jain 2020-10-07 12:40:14 PDT
Created attachment 410767 [details]
Comment 2 Aakash Jain 2020-10-07 13:01:23 PDT
Comment 3 dewei_zhu 2020-10-07 13:04:09 PDT
Comment 4 EWS 2020-10-07 15:09:28 PDT
Committed r268154: <https://trac.webkit.org/changeset/268154>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410767 [details].
Comment 5 Aakash Jain 2020-10-08 06:32:39 PDT
Restarted build.webkit.org to pick up this change.