Bug 217394 - [build.webkit.org] Ensure that steps names are valid Buildbot identifiers
Summary: [build.webkit.org] Ensure that steps names are valid Buildbot identifiers
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency treegraph
Reported: 2020-10-06 10:49 PDT by Aakash Jain
Modified: 2020-10-08 06:32 PDT (History)
5 users (show)

See Also:

Patch (45.12 KB, patch)
2020-10-06 11:10 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-10-06 10:49:16 PDT
[build.webkit.org] Ensure that steps names are valid buildbot identifiers

We are planning to upgrade build.webkit.org to latest buildbot. In buildbot 0.9+ step name is an identifier and can not contain space. 

As per http://docs.buildbot.net/0.9.8/manual/installation/nine-upgrade.html#identifiers :
"An "identifier" is a nonempty unicode string of limited length, containing only ASCII alphanumeric characters along with - (dash) and _ (underscore), and not beginning with a digit."

We should rename all the step names to not contain any space.
Comment 1 Aakash Jain 2020-10-06 10:49:38 PDT
Comment 2 Aakash Jain 2020-10-06 11:10:15 PDT
Created attachment 410661 [details]
Comment 3 EWS 2020-10-06 13:51:27 PDT
Committed r268071: <https://trac.webkit.org/changeset/268071>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410661 [details].
Comment 4 Aakash Jain 2020-10-08 06:32:04 PDT
Restarted build.webkit.org to pick up this change.