Bug 216569 - Import OscillatorNode layout tests from Blink
Summary: Import OscillatorNode layout tests from Blink
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 216625
Blocks: 212611 216576
  Show dependency tree / graph
 
Reported: 2020-09-15 10:16 PDT by Chris Dumez
Modified: 2020-09-16 17:17 PDT (History)
10 users (show)

See Also:

Attachments
Patch (93.20 KB, patch)
2020-09-15 10:18 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (3.92 MB, patch)
2020-09-15 11:49 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.92 MB, patch)
2020-09-15 12:12 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.92 MB, patch)
2020-09-15 13:00 PDT, Chris Dumez 		eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-15 10:16:44 PDT 
Import OscillatorNode layout tests from Blink.
Comment 1 Chris Dumez 2020-09-15 10:18:35 PDT 
Created attachment 408829 [details]
Patch
Comment 2 Geoffrey Garen 2020-09-15 11:33:21 PDT 
EWS seems angry.
Comment 3 Chris Dumez 2020-09-15 11:49:44 PDT 
Created attachment 408841 [details]
Patch
Comment 4 Chris Dumez 2020-09-15 12:12:35 PDT 
Created attachment 408843 [details]
Patch
Comment 5 Chris Dumez 2020-09-15 13:00:36 PDT 
Created attachment 408848 [details]
Patch
Comment 6 Chris Dumez 2020-09-15 13:39:27 PDT 
Comment on attachment 408848 [details]
Patch

Ready for review.
Comment 7 youenn fablet 2020-09-15 23:59:53 PDT 
Comment on attachment 408848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408848&action=review

> LayoutTests/ChangeLog:8
> +        Import OscillatorNode layout tests from Blink.

Do you know why these are not WPT tests?
Can we move them to LayoutTests/imported/w3c/web-platform-tests/webaudio and upstream them? They are already testharness based so should be fine.
That will make sure these tests will be kept in sync with Blink.
Comment 8 Chris Dumez 2020-09-16 08:24:32 PDT 
(In reply to youenn fablet from comment #7)
> Comment on attachment 408848 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408848&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        Import OscillatorNode layout tests from Blink.
> 
> Do you know why these are not WPT tests?
> Can we move them to LayoutTests/imported/w3c/web-platform-tests/webaudio and
> upstream them? They are already testharness based so should be fine.
> That will make sure these tests will be kept in sync with Blink.

These are Blink tests. I do not know why they were not upstreamed. I don't think we should be the ones to upstream them. Until they are upstreamed, the best thing I can do to gain test coverage and make sure we match Chrome behavior is to import them.

This is blocking my work.
Comment 9 EWS 2020-09-16 08:34:04 PDT 
Tools/Scripts/svn-apply failed to apply attachment 408848 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 10 Chris Dumez 2020-09-16 08:34:26 PDT 
<https://trac.webkit.org/changeset/267144>
Comment 11 Radar WebKit Bug Importer 2020-09-16 08:35:20 PDT 
<rdar://problem/68990849>
Comment 12 youenn fablet 2020-09-16 09:09:51 PDT 
I filed https://github.com/web-platform-tests/wpt/issues/25571, hopefully Chromium can do the upstream and we could then remove our own copy.