Bug 216625 - Regression(r267144) 4 webaudio/oscillator tests are broken
Summary: Regression(r267144) 4 webaudio/oscillator tests are broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 216569
  Show dependency tree / graph
 
Reported: 2020-09-16 16:39 PDT by Ryan Haddad
Modified: 2020-09-17 11:10 PDT (History)
11 users (show)

See Also:

Attachments
Patch (848.85 KB, patch)
2020-09-16 17:16 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2020-09-16 16:39:33 PDT 
The following tests were added with https://trac.webkit.org/changeset/267144/webkit and appear to be missing expected results

  webaudio/oscillator-custom.html [ Missing ]
  webaudio/oscillator-sawtooth.html [ Missing ]
  webaudio/oscillator-square.html [ Missing ]
  webaudio/oscillator-triangle.html [ Missing ]

https://build.webkit.org/results/Apple-Catalina-Release-WK1-Tests/r267166%20(9108)/results.html
Comment 1 Chris Dumez 2020-09-16 16:40:45 PDT 
Will fix shortly.
Comment 2 Ryan Haddad 2020-09-16 16:52:43 PDT 
I've got the change to add results, will land it now.
Comment 3 Ryan Haddad 2020-09-16 16:55:37 PDT 
Fixed in r267171.
Comment 4 Radar WebKit Bug Importer 2020-09-16 16:56:21 PDT 
<rdar://problem/69024624>
Comment 5 Ryan Haddad 2020-09-16 16:59:13 PDT 
Reverted r267171 for reason:

The tests need to be fixed

Committed r267173: <https://trac.webkit.org/changeset/267173>
Comment 6 Chris Dumez 2020-09-16 17:16:53 PDT 
Created attachment 408967 [details]
Patch
Comment 7 EWS 2020-09-17 11:10:39 PDT 
Committed r267201: <https://trac.webkit.org/changeset/267201>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408967 [details].