Bug 216576 - Merge PeriodicWave improvements from Blink
Summary: Merge PeriodicWave improvements from Blink
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 216569
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-09-15 12:32 PDT by Chris Dumez
Modified: 2020-09-16 10:41 PDT (History)
9 users (show)

See Also:

Attachments
Patch (195.87 KB, patch)
2020-09-15 12:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (142.61 KB, patch)
2020-09-15 13:03 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (142.69 KB, patch)
2020-09-16 09:05 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (142.70 KB, patch)
2020-09-16 09:50 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-15 12:32:09 PDT 
Merge PeriodicWave improvements from Blink.
Comment 1 Chris Dumez 2020-09-15 12:57:36 PDT 
Created attachment 408847 [details]
Patch
Comment 2 Chris Dumez 2020-09-15 13:03:21 PDT 
Created attachment 408849 [details]
Patch
Comment 3 Chris Dumez 2020-09-16 09:05:57 PDT 
Created attachment 408926 [details]
Patch
Comment 4 Darin Adler 2020-09-16 09:47:56 PDT 
Comment on attachment 408926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408926&action=review

> Source/WebCore/Modules/webaudio/PeriodicWave.cpp:47
> +// The number of bands per octave. Each octave will have this many entries in the wave tables.
> +const unsigned NumberOfOctaveBands = 3;
> +
> +// The max length of a periodic wave. This must be a power of two greater than
> +// or equal to 2048 and must be supported by the FFT routines.
> +const unsigned MaxPeriodicWaveSize = 16384;
> +
> +const float CentsPerRange = 1200 / NumberOfOctaveBands;

constexpr unless we want to leave this alone so it’s easier to merge from Chromium
Comment 5 Chris Dumez 2020-09-16 09:50:05 PDT 
Created attachment 408929 [details]
Patch
Comment 6 EWS 2020-09-16 10:40:19 PDT 
Committed r267153: <https://trac.webkit.org/changeset/267153>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408929 [details].
Comment 7 Radar WebKit Bug Importer 2020-09-16 10:41:19 PDT 
<rdar://problem/68998577>