In order to pass more WebGL 2.0 conformance tests, in particular some sRGB-related ones, WebKit's snapshot of ANGLE must be rolled forward to pick up recent upstream fixes.
Created attachment 405432 [details] Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
It looks like WinCairo doesn't build with USE(ZLIB) enabled. Any ideas how to stub out the compression-related functions in Source/ThirdParty/ANGLE/third_party/zlib/google/ ? To date we haven't put WebKit-style USE(...) macros in that code.
(In reply to Kenneth Russell from comment #3) > It looks like WinCairo doesn't build with USE(ZLIB) enabled. > > Any ideas how to stub out the compression-related functions in > Source/ThirdParty/ANGLE/third_party/zlib/google/ ? To date we haven't put > WebKit-style USE(...) macros in that code. From the build output it can't find a z_const definition. We don't use stock zlib we actually use zlib-ng. There's a PR for adding back z_const, https://github.com/zlib-ng/zlib-ng/pull/704, that should fix it. I would need to apply that to our requirements repository for the build to get further.
Created attachment 405479 [details] Patch
Created attachment 405488 [details] Patch
Thanks Don for your suggestion. Was able to put in a local workaround for the missing z_const preprocessor definition in the newly-introduced zlib wrapper in this patch. Now working through link errors in the WinCairo build.
Created attachment 405495 [details] Patch
Thanks achristensen@ for your review! Relieved that this is passing the WinCairo bot now. Will wait for more EWS bots to complete before marking this CQ+.
Everything's green. mac-debug-wk1 is backed up and hasn't started yet but it was green on earlier patches. CQ'ing now.
Committed r265064: <https://trac.webkit.org/changeset/265064> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405495 [details].
<rdar://problem/66296668>