Added constructors according to spec: https://www.w3.org/TR/webaudio/#ChannelMergerNode-constructors. Added new files for ChannelMergerOptions and ChannelSplitterOptions.
Created attachment 405315 [details] Patch
Created attachment 405354 [details] Patch
Comment on attachment 405354 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405354&action=review > Source/WebCore/Modules/webaudio/ChannelMergerNode.cpp:48 > + if (options.numberOfInputs > AudioContext::maxNumberOfChannels() || options.numberOfInputs <= 0) || !options.numberOfInputs numberOfInputs is unsigned so it cannot be negative. > Source/WebCore/Modules/webaudio/ChannelSplitterNode.cpp:42 > + if (options.numberOfOutputs > AudioContext::maxNumberOfChannels() || options.numberOfOutputs <= 0) || !options.numberOfOutputs > Source/WebCore/Modules/webaudio/ChannelSplitterNode.cpp:64 > + , m_numberOfOutputs(numberOfOutputs) Why do we need this data member? Looks like you could use existing numberOfOutputs() ?
(In reply to Chris Dumez from comment #3) > Comment on attachment 405354 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405354&action=review > > > Source/WebCore/Modules/webaudio/ChannelMergerNode.cpp:48 > > + if (options.numberOfInputs > AudioContext::maxNumberOfChannels() || options.numberOfInputs <= 0) > > || !options.numberOfInputs > > numberOfInputs is unsigned so it cannot be negative. > > > Source/WebCore/Modules/webaudio/ChannelSplitterNode.cpp:42 > > + if (options.numberOfOutputs > AudioContext::maxNumberOfChannels() || options.numberOfOutputs <= 0) > > || !options.numberOfOutputs > > > Source/WebCore/Modules/webaudio/ChannelSplitterNode.cpp:64 > > + , m_numberOfOutputs(numberOfOutputs) > > Why do we need this data member? Looks like you could use existing > numberOfOutputs() ? Ah, I didn't know of this method. Thanks!
Created attachment 405379 [details] Patch
Committed r265002: <https://trac.webkit.org/changeset/265002> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405379 [details].
<rdar://problem/66233763>
(In reply to EWS from comment #6) > Committed r265002: <https://trac.webkit.org/changeset/265002> This broke imported/w3c/web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output.html for mac-debug-wk1. EWS also indicated this on previous version on this patch. History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebaudio%2Fthe-audio-api%2Fthe-scriptprocessornode-interface%2Fsimple-input-output.html
Re-opened since this is blocked by bug 214919
Created attachment 405483 [details] Patch
Comment on attachment 405379 [details] Patch Splitting fix for crash to Bug 214931. The constructors added in this patch will have to be updated accordingly too.
Created attachment 405500 [details] Patch
Comment on attachment 405500 [details] Patch r=me
Comment on attachment 405500 [details] Patch Clearing flags on attachment: 405500 Committed r265066: <https://trac.webkit.org/changeset/265066>
All reviewed patches have been landed. Closing bug.