Bug 214931 - Calling AudioNode constructors should have identical behavior to using create*() function on BaseAudioContext
Summary: Calling AudioNode constructors should have identical behavior to using create...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611 214851
  Show dependency treegraph
 
Reported: 2020-07-29 12:38 PDT by Chris Dumez
Modified: 2020-07-29 13:25 PDT (History)
9 users (show)

See Also:


Attachments
Patch (8.49 KB, patch)
2020-07-29 12:41 PDT, Chris Dumez
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-07-29 12:38:27 PDT
Calling AudioNode constructors should have identical behavior than using create*() function on BaseAudioContext. Otherwise, this leads to assertion hits like:
https://ews-build.s3-us-west-2.amazonaws.com/macOS-Mojave-Debug-WK1-Tests-EWS/r405354-14671/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-crash-log.txt

We need to make sure that the AudioContext gets initialized when an AudioNode constructor gets called. We also need to make sure refNode() gets called if necessary.
Comment 1 Chris Dumez 2020-07-29 12:41:47 PDT
Created attachment 405486 [details]
Patch
Comment 2 Eric Carlson 2020-07-29 13:07:37 PDT
Comment on attachment 405486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405486&action=review

> Source/WebCore/ChangeLog:3
> +        Calling AudioNode constructors should have identical behavior than using create*() function on BaseAudioContext

s/identical behavior than using create/identical behavior to using create/

> Source/WebCore/ChangeLog:8
> +        Calling AudioNode constructors should have identical behavior than using create*() function on BaseAudioContext.

Ditto.
Comment 3 Chris Dumez 2020-07-29 13:24:51 PDT
Committed r265052: <https://trac.webkit.org/changeset/265052>
Comment 4 Radar WebKit Bug Importer 2020-07-29 13:25:24 PDT
<rdar://problem/66289207>