The change in r261152 intended to remove no-longer-needed conditionals that are now always true on Cocoa platforms.
However, when I made that change I accidentally left 9 blocks of code guarded by HAVE(SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN) behind. So these were all disabled!
These 9 blocks of code must either be:
1) enabled unconditionally
2) guarded by #HAVE(AUDIT_TOKEN)
3) guarded by ENABLE(SANDBOX_EXTENSIONS)
Created attachment 404096 [details]
Patch enables these code paths unconditionally. I’ll count on EWS to detect if I need to guard these with HAVE(AUDIO_TOKEN) or ENABLE(SANDBOX_EXTENSIONS).
To fix the WinCairo build I am working on a revised version that puts more code inside ENABLE(SANDBOX_EXTENSIONS).
Created attachment 404098 [details]
Created attachment 404099 [details]
Created attachment 404101 [details]
Ended up adding a couple ENABLE(SANDBOX_EXTENSIONS) guards. Patch is ready for review now.
Comment on attachment 404101 [details]
Committed r264283: <https://trac.webkit.org/changeset/264283>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 404101 [details].
WinCairo can't load local files since this change.
Filed: Bug 214248 – [WinCairo][WK2] REGRESSION (r264283): Can't load file: URL