Bug 214244 - [GTK][WPE] WTR and API-tests timing out after r264283
Summary: [GTK][WPE] WTR and API-tests timing out after r264283
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
: 214248 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-07-12 19:46 PDT by Lauro Moura
Modified: 2020-07-13 09:13 PDT (History)
12 users (show)

See Also:


Attachments
WIP patch (7.46 KB, patch)
2020-07-13 00:09 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (7.78 KB, patch)
2020-07-13 00:59 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (7.51 KB, patch)
2020-07-13 02:29 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-07-12 19:46:12 PDT
All WTR tests exiting early due to all tests timing out.

For example, fast/css/tab-size.html gets stuck in the platformRunUntil waiting for the response from WKPageLoadURLWithShouldOpenExternalURLsPolicy in the TestInvocation.cpp.

Sample WTR output: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/14627/steps/layout-test/logs/stdio

Some API tests also exiting, many from the C API tests where pages are loaded.

For example, /TestWebKit WebKit.PageLoadTwiceAndReload gets stuck with none of the two loaderClient callbacks (didFinishNavigation and didFailProvisionalNavigation) being called.

Sample API tests output: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/14627/steps/API%20tests/logs/stdio
Comment 1 Lauro Moura 2020-07-12 20:49:31 PDT
More info:

Minibrowser seems to be working file. Checking the Loading channel from systemd:

WTR (fails):

jul 13 00:06:55 lauro-desktop WebKitWebProcess[88070]: 0x7f6a926fa3b0 - [pageID=8, frameID=3] PolicyChecker::checkNavigationPolicy: continuing because this is an initial empty document
jul 13 00:06:55 lauro-desktop WebKitWebProcess[88070]: 0x7f6a926fa3b0 - [pageID=8, frameID=3] PolicyChecker::checkNavigationPolicy: ignoring because policyAction from dispatchDecidePolicyForNavigationAction is Ignore

From Minibrowser (works):

jul 13 00:09:24 lauro-desktop WebKitWebProcess[89059]: 0x7f65e6cfa400 - [pageID=6, frameID=3] PolicyChecker::checkNavigationPolicy: continuing because this policyAction from dispatchDecidePolicyForNavigationAction is Use
Comment 2 Zan Dobersek 2020-07-13 00:09:23 PDT
Created attachment 404129 [details]
WIP patch
Comment 3 Zan Dobersek 2020-07-13 00:59:43 PDT
Created attachment 404130 [details]
Patch
Comment 4 Zan Dobersek 2020-07-13 02:29:44 PDT
Created attachment 404136 [details]
Patch for landing
Comment 5 Zan Dobersek 2020-07-13 02:31:28 PDT
*** Bug 214248 has been marked as a duplicate of this bug. ***
Comment 6 Zan Dobersek 2020-07-13 02:32:09 PDT
Comment on attachment 404136 [details]
Patch for landing

Clearing flags on attachment: 404136

Committed r264297: <https://trac.webkit.org/changeset/264297>
Comment 7 Zan Dobersek 2020-07-13 02:32:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Darin Adler 2020-07-13 09:13:14 PDT
Thanks, this looks fine to me.