Bug 211427 - Remove now-unneeded HAVE(SANDBOX_ISSUE_MACH/READ_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN)
Summary: Remove now-unneeded HAVE(SANDBOX_ISSUE_MACH/READ_EXTENSION_TO_PROCESS_BY_AUDI...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-04 20:20 PDT by Darin Adler
Modified: 2020-07-12 08:02 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.06 KB, patch)
2020-05-04 20:21 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-05-04 20:20:29 PDT 
Remove now-unneeded HAVE(SANDBOX_ISSUE_MACH/READ_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN)
Comment 1 Darin Adler 2020-05-04 20:21:07 PDT 
Created attachment 398464 [details]
Patch
Comment 2 EWS 2020-05-04 22:47:27 PDT 
Committed r261152: <https://trac.webkit.org/changeset/261152>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398464 [details].
Comment 3 Radar WebKit Bug Importer 2020-05-04 22:48:16 PDT 
<rdar://problem/62875952>
Comment 4 Darin Adler 2020-07-12 08:02:28 PDT 
This patch was incorrect. There were many instances of HAVE(SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN) left behind that this accidentally disabled!

But no tests that detected this screwup.

Will use bug 214233 to fix the problem, and interested in finding a way to add tests as well.