RESOLVED FIXED 21026
No favicon during first load 
https://bugs.webkit.org/show_bug.cgi?id=21026
Summary No favicon during first load
Patrick
Reported 2008-09-23 09:20:33 PDT
Safari -> Reset Safari... Go to a site known to have a favicon (google.com, yahoo.com, ebay.com, etc). Notice there is no favicon until you refresh the site. I turned on logging and I think the issue is that the favicon data has not been committed to the database in dispatchDidReceiveIcon and dispatchDidAddIconForPageURL so that the Image stored in the IconRecord has m_data set to NULL.
Attachments
Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2008-09-23 14:14:06 PDT
<rdar://problem/6240826>
Patrick
Comment 2 2008-10-07 06:44:19 PDT
I have a local change that switches the order of readFromDatabase() and writeToDatabase() inside IconDatabase::syncThreadMainLoop() that appears to fix the issue. I haven't seen any adverse affects but I'm not sure what to look for.
David Kilzer (:ddkilzer)
Comment 3 2008-12-10 13:31:18 PST
See also Bug 12892.
David Kilzer (:ddkilzer)
Comment 4 2008-12-10 13:55:45 PST
I believe Attachment #25925 [details] from Bug 22795 contains a (webarchive) test case that reproduces this issue reliably on Mac OS X, which should make it easier to fix.
Darin Adler
Comment 5 2008-12-25 10:17:23 PST
Could this be related to the "write before read" change in bug 22963?
David Kilzer (:ddkilzer)
Comment 6 2008-12-29 16:18:44 PST
(In reply to comment #5) > Could this be related to the "write before read" change in bug 22963? I don't believe that patch fixes the issue. See Bug 22963 Comment #3.
David Kilzer (:ddkilzer)
Comment 7 2009-01-14 14:18:07 PST
(In reply to comment #4) > I believe Attachment #25925 [details] [review] from Bug 22795 contains a (webarchive) test case > that reproduces this issue reliably on Mac OS X, which should make it easier to > fix. The fix for Bug 22795 landed, but the layout test fails in different ways on different buildbots (see Bug 23331), so it's currently disabled.
David Kilzer (:ddkilzer)
Comment 8 2009-01-28 19:49:54 PST
I think this may have been fixed with <http://trac.webkit.org/changeset/40335>. Patrick, could you verify this with a nightly build?
Patrick
Comment 9 2009-01-29 05:28:39 PST
I think change 40335 and the fix for bug 22963 have resolved this issue.
David Kilzer (:ddkilzer)
Comment 10 2009-01-29 08:02:00 PST
(In reply to comment #9) > I think change 40335 and the fix for bug 22963 have resolved this issue. Resolving as fixed.
Note You need to log in before you can comment on or make changes to this bug.