Bug 23331 - LayoutTests/webarchive/test-link-rel-icon.html fails in different ways on buildbots
Summary: LayoutTests/webarchive/test-link-rel-icon.html fails in different ways on bui...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2009-01-14 14:09 PST by David Kilzer (:ddkilzer)
Modified: 2009-05-11 10:07 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (5.24 KB, patch)
2009-05-11 09:39 PDT, David Kilzer (:ddkilzer) 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2009-01-14 14:09:35 PST 
* SUMMARY
The webarchive/test-link-rel-icon.html test fails in different ways on different buildbots.

On PPC Tiger <http://build.webkit.org/results/trunk-mac-ppc-release/16131/>:

 				<key>expectedContentLength</key>
-				<integer>0</integer>
+				<integer>1150</integer>

On Intel Leopard(?) <http://build.webkit.org/results/trunk-mac-intel-pixel/1370/>, the entire favicon resource is missing from the webarchive.

Disabling this test for now to keep the buildbots green.
Comment 1 David Kilzer (:ddkilzer) 2009-01-14 14:17:17 PST 
See also Bug 22795 (which added this test) and Bug 21026 (which may fix these issues once its issue is fixed).
Comment 2 David Kilzer (:ddkilzer) 2009-01-14 14:18:53 PST 
(In reply to comment #0)
> Disabling this test for now to keep the buildbots green.

$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	R	LayoutTests/webarchive/test-link-rel-icon.html => LayoutTests/webarchive/test-link-rel-icon.html-disabled
	M	LayoutTests/ChangeLog
Committed r39911

http://trac.webkit.org/changeset/39911
Comment 3 David Kilzer (:ddkilzer) 2009-01-28 19:48:07 PST 
This layout test may work again after <http://trac.webkit.org/changeset/40335>.
Comment 4 David Kilzer (:ddkilzer) 2009-05-11 09:39:09 PDT 
Created attachment 30191 [details]
Patch v1

This was reviewed by Brady.
Comment 5 David Kilzer (:ddkilzer) 2009-05-11 09:45:48 PDT 
$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	D	LayoutTests/webarchive/test-link-rel-icon.html-disabled
	M	LayoutTests/ChangeLog
	M	LayoutTests/webarchive/test-link-rel-icon-expected.webarchive
	A	LayoutTests/webarchive/test-link-rel-icon.html
Committed r43499

http://trac.webkit.org/changeset/43499
Comment 6 David Kilzer (:ddkilzer) 2009-05-11 10:07:15 PDT 
Added webarchive/test-link-rel-icon.html to the gtk Skipped list:

$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/gtk/Skipped
Committed r43501

http://trac.webkit.org/changeset/43501