Bug 22963 - write icons before reading them
Summary: write icons before reading them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-22 08:48 PST by Cary Clark
Modified: 2009-01-02 18:36 PST (History)
2 users (show)

See Also:


Attachments
reverse order of reading, writing icons to database (1.50 KB, patch)
2008-12-22 08:50 PST, Cary Clark
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cary Clark 2008-12-22 08:48:16 PST
Write the pending icons to the database before trying to read any requested icons to ensure that a requested icon has the correct data.
Comment 1 Cary Clark 2008-12-22 08:50:50 PST
Created attachment 26204 [details]
reverse order of reading, writing icons to database
Comment 2 Darin Adler 2008-12-24 23:07:20 PST
Comment on attachment 26204 [details]
reverse order of reading, writing icons to database

Looks good. r=me
Comment 3 David Kilzer (:ddkilzer) 2008-12-27 03:12:14 PST
Although this is a good fix, it doesn't appear to resolve the workaround for Bug 21026 in the layout test for Bug 22795.

Comment 4 Darin Adler 2009-01-02 18:36:13 PST
http://trac.webkit.org/changeset/39569