Bug 210190 - [ews] rename CompileWebKitToT to CompileWebKitWithoutPatch
Summary: [ews] rename CompileWebKitToT to CompileWebKitWithoutPatch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-08 08:50 PDT by Aakash Jain
Modified: 2020-04-09 05:25 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.90 KB, patch)
2020-04-08 09:00 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-04-08 08:50:42 PDT
Rename CompileWebKitToT to CompileWebKitWithoutPatch since that's more accurate name. In EWS, when the CompileWebKit fails, we un-apply the patch and compile same revision without patch, not the ToT.

This naming would also make it consistent with other similar steps like: RunWebKitTestsWithout, RunAPITestsWithoutPatch and RunJSCTestsWithoutPatch.
Comment 1 Aakash Jain 2020-04-08 09:00:46 PDT
Created attachment 395819 [details]
Patch
Comment 2 EWS 2020-04-09 03:06:05 PDT
Committed r259787: <https://trac.webkit.org/changeset/259787>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395819 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-09 03:07:14 PDT
<rdar://problem/61507229>