Bug 203959 - [ews] rename RunJavaScriptCoreTestsToT to RunJSCTestsWithoutPatch
Summary: [ews] rename RunJavaScriptCoreTestsToT to RunJSCTestsWithoutPatch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-07 09:09 PST by Aakash Jain
Modified: 2019-11-07 10:32 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.05 KB, patch)
2019-11-07 09:12 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-11-07 09:09:17 PST
Rename RunJavaScriptCoreTestsToT to RunJSCTestsWithoutPatch since that's more accurate name. In EWS, when the jsc tests fails, we un-apply the patch and run tests on clean tree, not on ToT. We re-run the tests without patch on same revision on which tests were run with the patch.

This naming would also make it consistent with other similar steps like: RunWebKitTestsWithout and RunAPITestsWithoutPatch.
Comment 1 Aakash Jain 2019-11-07 09:12:41 PST
Created attachment 383056 [details]
Patch
Comment 2 Alexey Proskuryakov 2019-11-07 09:24:08 PST
Comment on attachment 383056 [details]
Patch

Why is webkitperl EWS red?
Comment 3 Aakash Jain 2019-11-07 09:54:45 PST
(In reply to Alexey Proskuryakov from comment #2)
> Why is webkitperl EWS red?
Not sure. It passed on retry. Filed: https://bugs.webkit.org/show_bug.cgi?id=203964
Comment 4 WebKit Commit Bot 2019-11-07 10:31:02 PST
Comment on attachment 383056 [details]
Patch

Clearing flags on attachment: 383056

Committed r252190: <https://trac.webkit.org/changeset/252190>
Comment 5 WebKit Commit Bot 2019-11-07 10:31:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-07 10:32:15 PST
<rdar://problem/56987785>