WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
210265
[ews] rename CompileJSCToT to CompileJSCWithoutPatch
https://bugs.webkit.org/show_bug.cgi?id=210265
Summary
[ews] rename CompileJSCToT to CompileJSCWithoutPatch
Aakash Jain
Reported
2020-04-09 05:14:02 PDT
Rename CompileJSCToT to CompileJSCWithoutPatch since that's more accurate name. In EWS, when the CompileJSC fails, we un-apply the patch and compile same revision without patch, not the ToT. This naming would also make it consistent with other similar steps like: CompileWebKitWithoutPatch, RunWebKitTestsWithout, RunAPITestsWithoutPatch and RunJSCTestsWithoutPatch.
Attachments
Patch
(6.42 KB, patch)
2020-04-09 05:22 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2020-04-09 05:22:24 PDT
Created
attachment 395938
[details]
Patch
EWS
Comment 2
2020-04-09 11:18:02 PDT
Committed
r259809
: <
https://trac.webkit.org/changeset/259809
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 395938
[details]
.
Radar WebKit Bug Importer
Comment 3
2020-04-09 11:19:13 PDT
<
rdar://problem/61528367
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug