Bug 210265 - [ews] rename CompileJSCToT to CompileJSCWithoutPatch
Summary: [ews] rename CompileJSCToT to CompileJSCWithoutPatch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-09 05:14 PDT by Aakash Jain
Modified: 2020-04-09 11:19 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.42 KB, patch)
2020-04-09 05:22 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-04-09 05:14:02 PDT 
Rename CompileJSCToT to CompileJSCWithoutPatch since that's more accurate name. In EWS, when the CompileJSC fails, we un-apply the patch and compile same revision without patch, not the ToT.

This naming would also make it consistent with other similar steps like: CompileWebKitWithoutPatch, RunWebKitTestsWithout, RunAPITestsWithoutPatch and RunJSCTestsWithoutPatch.
Comment 1 Aakash Jain 2020-04-09 05:22:24 PDT 
Created attachment 395938 [details]
Patch
Comment 2 EWS 2020-04-09 11:18:02 PDT 
Committed r259809: <https://trac.webkit.org/changeset/259809>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395938 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-09 11:19:13 PDT 
<rdar://problem/61528367>