WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
207471
[WPE] Use custom theme style to render buttons
https://bugs.webkit.org/show_bug.cgi?id=207471
Summary
[WPE] Use custom theme style to render buttons
Carlos Garcia Campos
Reported
2020-02-10 09:31:58 PST
Push, check and radio buttons.
Attachments
Patch
(16.64 KB, patch)
2020-02-10 09:38 PST
,
Carlos Garcia Campos
aperez
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2020-02-10 09:38:40 PST
Created
attachment 390256
[details]
Patch
Adrian Perez
Comment 2
2020-02-17 01:43:48 PST
Comment on
attachment 390256
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=390256&action=review
I left just a small comment, otherwise LGTM :)
> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:54 > +static const int menuListButtonBorderSize = 1; // Keep in sync with buttonBorderSize in Theme.
I would also add a similar comment inside “ThemeWPE.cpp” warning “Keep in sync with menuListButtonBorderSize in RenderTheme” so no matter which file one is editing, there's always a note to ensure that the other one is kept in sync =)
Carlos Garcia Campos
Comment 3
2020-02-17 02:13:08 PST
Committed
r256726
: <
https://trac.webkit.org/changeset/256726
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug