Bug 207686 – [WPE] Add support for rendering spin buttons

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Carlos Garcia Campos]

.

[Carlos Garcia Campos]

Created attachment 390626 [details]
Patch

[Adrian Perez]

Comment on attachment 390626 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390626&action=review

r+, but please check the comment below before landing.

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:50
> +static const unsigned menuListButtonArrowSize = 16;

Does this need to have the same value as “arrowSize“ in ThemeWPE.cpp?
If yes, please add a comment here saying so.

> Source/WebCore/platform/wpe/ThemeWPE.cpp:40
> +static const unsigned arrowSize = 16;

If this needs to have the same size as “menuListButtonArrowSize” in
RenderThemeWPE.cpp, please add a comment indicating that.

[Carlos Garcia Campos]

(In reply to Adrian Perez from comment #2)
> Comment on attachment 390626 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390626&action=review
> 
> r+, but please check the comment below before landing.
> 
> > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:50
> > +static const unsigned menuListButtonArrowSize = 16;
> 
> Does this need to have the same value as “arrowSize“ in ThemeWPE.cpp?
> If yes, please add a comment here saying so.

Not necessarily, the arrow can be scaled, but we never scale it in case of menu list button. It's true that we don't scale it because we know the arrow size is 16 too, but still. 

> > Source/WebCore/platform/wpe/ThemeWPE.cpp:40
> > +static const unsigned arrowSize = 16;
> 
> If this needs to have the same size as “menuListButtonArrowSize” in
> RenderThemeWPE.cpp, please add a comment indicating that.

[Carlos Garcia Campos]

Committed r256823: <https://trac.webkit.org/changeset/256823>