Bug 207379 - [WPE] Use custom theme style to render text fields
Summary: [WPE] Use custom theme style to render text fields
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 207471
  Show dependency tree / graph
 
Reported: 2020-02-07 02:20 PST by Carlos Garcia Campos
Modified: 2020-02-17 01:08 PST (History)
11 users (show)

See Also:

Attachments
Patch (10.61 KB, patch)
2020-02-07 02:25 PST, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-02-07 02:20:41 PST 
This includes text entries, text areas and search fields.
Comment 1 Carlos Garcia Campos 2020-02-07 02:25:40 PST 
Created attachment 390069 [details]
Patch
Comment 2 Adrian Perez 2020-02-14 06:18:09 PST 
Comment on attachment 390069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390069&action=review

Patch LGTM with a small unimportant nit :]

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:43
> +static const int textFieldBorderSize = 1;

Nit: I would use “unsigned” here, as it does not make sense to allow
negative values for a border.
Comment 3 Carlos Garcia Campos 2020-02-14 06:27:29 PST 
Comment on attachment 390069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390069&action=review

>> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:43
>> +static const int textFieldBorderSize = 1;
> 
> Nit: I would use “unsigned” here, as it does not make sense to allow
> negative values for a border.

It's used with negative value for .inflate(), that's why I changed it to int.

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:128
> +    fieldRect.inflate(-borderSize);

Here.
Comment 4 Carlos Garcia Campos 2020-02-17 01:08:00 PST 
Committed r256724: <https://trac.webkit.org/changeset/256724>