RESOLVED FIXED 206825
webkitpy: Replace StringIO.StringIO in statusserver.py 
https://bugs.webkit.org/show_bug.cgi?id=206825
Summary webkitpy: Replace StringIO.StringIO in statusserver.py
Jonathan Bedard
Reported 2020-01-27 07:50:19 PST
This bug was brought to my attention in https://bugs.webkit.org/show_bug.cgi?id=206801, and is apparently not covered in our unit testing.
Attachments
Patch (2.00 KB, patch)
2020-01-27 07:51 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-01-27 07:51:50 PST
Created attachment 388858 [details] Patch
Aakash Jain
Comment 2 2020-01-27 07:56:54 PST
Comment on attachment 388858 [details] Patch This is actually dead code after https://trac.webkit.org/changeset/255123/webkit I plan to delete a lot of code of old EWS after moving commit-queue. But I am fine with fixing this issue meanwhile.
Jonathan Bedard
Comment 3 2020-01-27 08:00:44 PST
(In reply to Aakash Jain from comment #2) > Comment on attachment 388858 [details] > Patch > > This is actually dead code after > https://trac.webkit.org/changeset/255123/webkit > I plan to delete a lot of code of old EWS after moving commit-queue. > > But I am fine with fixing this issue meanwhile. Good to know. I'll land this now, but I look forward to the incoming deletion patches!
WebKit Commit Bot
Comment 4 2020-01-27 08:32:00 PST
Comment on attachment 388858 [details] Patch Clearing flags on attachment: 388858 Committed r255148: <https://trac.webkit.org/changeset/255148>
WebKit Commit Bot
Comment 5 2020-01-27 08:32:01 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-01-27 08:32:13 PST
<rdar://problem/58919230>
Aakash Jain
Comment 7 2020-03-27 15:21:06 PDT
(In reply to Jonathan Bedard from comment #3) > I look forward to the incoming deletion patches! Bug 209683 deletes a lot of code.
Note You need to log in before you can comment on or make changes to this bug.