RESOLVED FIXED 209683
Delete code for security EWS from old EWS 
https://bugs.webkit.org/show_bug.cgi?id=209683
Summary Delete code for security EWS from old EWS
Aakash Jain
Reported 2020-03-27 15:14:14 PDT
Old EWS has been deprecated. All the queues have been moved to new EWS. We should delete the code which was added to support security bugs in old EWS. New EWS implements security EWS in completely different manner.
Attachments
Patch (67.59 KB, patch)
2020-03-27 15:20 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-03-27 15:20:42 PDT
Created attachment 394764 [details] Patch
Aakash Jain
Comment 2 2020-03-27 15:24:22 PDT
(In reply to Aakash Jain from comment #1) > Created attachment 394764 [details] This reverts r232979, r233061, r233190, r233219, r233276 and r233288. It also take cares of maintaining Python 3 support (e.g. retaining changes from r251374).
Kocsen Chung
Comment 3 2020-03-27 16:08:17 PDT
Comment on attachment 394764 [details] Patch Looks good to me.
Jonathan Bedard
Comment 4 2020-03-30 08:48:58 PDT
This is a really difficult patch to review, not because it's bad code, but because it's reverting code that is unfortunately coupled tightly with code that we still need. I'm going to Rubber-stamp it because it's passed tests and, as far as I can tell, does what it claims to. Difficult for me to be certain about that, though, this isn't code I'm very familiar with.
Jonathan Bedard
Comment 5 2020-03-30 08:49:05 PDT
rs=me
Aakash Jain
Comment 6 2020-03-30 11:26:06 PDT
Committed r259212: <https://trac.webkit.org/changeset/259212>
Radar WebKit Bug Importer
Comment 7 2020-03-30 11:27:12 PDT
<rdar://problem/61064617>
Aakash Jain
Comment 8 2020-03-31 09:54:14 PDT
Committed r259295 <https://trac.webkit.org/changeset/259295> (which reverts r233220).
Note You need to log in before you can comment on or make changes to this bug.