Bug 206801 - webkit-patch upload should not submit automatically to old EWS
Summary: webkit-patch upload should not submit automatically to old EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-25 10:44 PST by Aakash Jain
Modified: 2020-01-25 12:03 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.68 KB, patch)
2020-01-25 10:55 PST, Aakash Jain
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-01-25 10:44:34 PST
Peng reported following error while trying to use webkit-patch upload.

Traceback (most recent call last):
 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkit-patch”, line 80, in <module>
  main()
 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkit-patch”, line 75, in main
  WebKitPatch(os.path.abspath(__file__)).main()
 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py”, line 305, in main
  result = command.check_arguments_and_execute(options, args, self)
 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py”, line 123, in check_arguments_and_execute
  return self.execute(options, args, tool) or 0
 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py”, line 55, in execute
  self._sequence.run_and_handle_errors(tool, options, state)
 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py”, line 73, in run_and_handle_errors
  self._run(tool, options, state)
 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py”, line 67, in _run
  step(tool, options).run(state)
 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/submittoews.py”, line 42, in run
  self._tool.status_server.upload_attachment(attachment)
 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/statusserver.py”, line 156, in upload_attachment
  return NetworkTransaction(convert_404_to_None=True).run(lambda: self._upload_attachment_to_server(attachment.id(), attachment.to_json(), attachment.contents()))
 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/networktransaction.py”, line 58, in run
  return request()
 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/statusserver.py”, line 156, in <lambda>
  return NetworkTransaction(convert_404_to_None=True).run(lambda: self._upload_attachment_to_server(attachment.id(), attachment.to_json(), attachment.contents()))
 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/statusserver.py”, line 147, in _upload_attachment_to_server
  self._browser.add_file(StringIO.StringIO(unicode(attachment_metadata)), ‘application/json’, ‘attachment-{}-metadata.json’.format(attachment_id), ‘attachment_metadata’)
AttributeError: class StringIO has no attribute ‘StringIO’
Comment 1 Aakash Jain 2020-01-25 10:51:03 PST
The error is while uploading the patch (for security bug) to old EWS.

We don't need to upload to old EWS anymore since almost all the queues have been removed from old EWS (moved to new EWS). Only queue remaining on old EWS is commit-queue (which doesn't support security bugs anyways).
Comment 2 Aakash Jain 2020-01-25 10:55:33 PST
Created attachment 388781 [details]
Patch
Comment 3 Aakash Jain 2020-01-25 10:57:37 PST
Reverting part of r232979 ,  https://trac.webkit.org/changeset/232979/webkit/trunk/Tools/Scripts/webkitpy/tool/steps/submittoews.py

webkit-patch upload wouldn't automatically submit to old EWS with that. However old EWS would continue fetching/processing patches based on the bugzilla flags (like r?/cq+).
Comment 4 Aakash Jain 2020-01-25 12:02:05 PST
Committed r255123: <https://trac.webkit.org/changeset/255123>
Comment 5 Radar WebKit Bug Importer 2020-01-25 12:03:12 PST
<rdar://problem/58896244>