Peng reported following error while trying to use webkit-patch upload. Traceback (most recent call last): File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkit-patch”, line 80, in <module> main() File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkit-patch”, line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py”, line 305, in main result = command.check_arguments_and_execute(options, args, self) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py”, line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py”, line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py”, line 73, in run_and_handle_errors self._run(tool, options, state) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py”, line 67, in _run step(tool, options).run(state) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/submittoews.py”, line 42, in run self._tool.status_server.upload_attachment(attachment) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/statusserver.py”, line 156, in upload_attachment return NetworkTransaction(convert_404_to_None=True).run(lambda: self._upload_attachment_to_server(attachment.id(), attachment.to_json(), attachment.contents())) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/networktransaction.py”, line 58, in run return request() File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/statusserver.py”, line 156, in <lambda> return NetworkTransaction(convert_404_to_None=True).run(lambda: self._upload_attachment_to_server(attachment.id(), attachment.to_json(), attachment.contents())) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/statusserver.py”, line 147, in _upload_attachment_to_server self._browser.add_file(StringIO.StringIO(unicode(attachment_metadata)), ‘application/json’, ‘attachment-{}-metadata.json’.format(attachment_id), ‘attachment_metadata’) AttributeError: class StringIO has no attribute ‘StringIO’
The error is while uploading the patch (for security bug) to old EWS. We don't need to upload to old EWS anymore since almost all the queues have been removed from old EWS (moved to new EWS). Only queue remaining on old EWS is commit-queue (which doesn't support security bugs anyways).
Created attachment 388781 [details] Patch
Reverting part of r232979 , https://trac.webkit.org/changeset/232979/webkit/trunk/Tools/Scripts/webkitpy/tool/steps/submittoews.py webkit-patch upload wouldn't automatically submit to old EWS with that. However old EWS would continue fetching/processing patches based on the bugzilla flags (like r?/cq+).
Committed r255123: <https://trac.webkit.org/changeset/255123>
<rdar://problem/58896244>