Bug 206544 - Performance tests fail if stderr logging is encountered
Summary: Performance tests fail if stderr logging is encountered
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 200543
Blocks:
  Show dependency tree / graph
 
Reported: 2020-01-21 11:38 PST by Brent Fulgham
Modified: 2020-01-21 12:34 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2020-01-21 11:40 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-01-21 11:38:50 PST 
In Bug 200543 (and other updates) we changed our sandbox code to use vend extensions to processes by audit token. During this change, we used the WTFLogAlways() logging function when a sandbox extension could not be created.

We now see that any output to stderr causes the test runner used by the micro-benchmark system in PerformanceTests to trigger a failure.

Now that we have debugged this code, we should switch back to our standard logging behavior.
Comment 1 Brent Fulgham 2020-01-21 11:39:54 PST 
<rdar://problem/58714766>
Comment 2 Brent Fulgham 2020-01-21 11:40:44 PST 
Created attachment 388328 [details]
Patch
Comment 3 Per Arne Vollan 2020-01-21 11:44:46 PST 
Comment on attachment 388328 [details]
Patch

Great! R=me.
Comment 4 WebKit Commit Bot 2020-01-21 12:34:48 PST 
Comment on attachment 388328 [details]
Patch

Clearing flags on attachment: 388328

Committed r254872: <https://trac.webkit.org/changeset/254872>
Comment 5 WebKit Commit Bot 2020-01-21 12:34:50 PST 
All reviewed patches have been landed.  Closing bug.