WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
206545
PerformanceTests should not treat stderr output as a test failure
https://bugs.webkit.org/show_bug.cgi?id=206545
Summary
PerformanceTests should not treat stderr output as a test failure
Brent Fulgham
Reported
2020-01-21 11:41:56 PST
The PerformanceTests test harness treats any stderr output as a test failure. Instead, it should treat it like the normal test system, where stderr is captured and noted, but does not contribute to the pass or fail status of a test.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-01-21 11:42:09 PST
<
rdar://problem/58767355
>
Alexey Proskuryakov
Comment 2
2020-01-21 12:39:20 PST
IIRC Ryosuke found it very important to catch errors on this way. Perhaps this is less relevant after redoing much of the logging system?
Ryosuke Niwa
Comment 3
2020-01-21 23:38:17 PST
(In reply to Brent Fulgham from
comment #0
)
> The PerformanceTests test harness treats any stderr output as a test > failure. Instead, it should treat it like the normal test system, where > stderr is captured and noted, but does not contribute to the pass or fail > status of a test.
I don't think we want to do this. Some of our internal benchmarks get broken all the time because we ignore all error messages.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug