Bug 200543 - [Mac] Use the PID of the WebContent process when issuing local file read sandbox extensions
Summary: [Mac] Use the PID of the WebContent process when issuing local file read sand...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on: 200772
Blocks:
  Show dependency treegraph
 
Reported: 2019-08-08 11:23 PDT by Per Arne Vollan
Modified: 2019-08-15 10:19 PDT (History)
8 users (show)

See Also:


Attachments
Patch (7.11 KB, patch)
2019-08-08 11:47 PDT, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff
Patch (7.12 KB, patch)
2019-08-08 12:47 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-08-08 11:23:01 PDT
When issuing local file read sandbox extensions, use the process identifier of the WebContent process.
Comment 1 Per Arne Vollan 2019-08-08 11:28:33 PDT
rdar://problem/49394015
Comment 2 Per Arne Vollan 2019-08-08 11:47:47 PDT
Created attachment 375829 [details]
Patch
Comment 3 Brent Fulgham 2019-08-08 12:24:47 PDT
Comment on attachment 375829 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375829&action=review

Looks good.

> Source/WebKit/ChangeLog:9
> +        the WebContent process.

Maybe it would be better phrased as:

"Adopt SPI to issue a process-specific sandbox extension for local file read, passing it the process identifier of the WebContent process."
Comment 4 Per Arne Vollan 2019-08-08 12:43:12 PDT
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 375829 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375829&action=review
> 
> Looks good.
> 
> > Source/WebKit/ChangeLog:9
> > +        the WebContent process.
> 
> Maybe it would be better phrased as:
> 
> "Adopt SPI to issue a process-specific sandbox extension for local file
> read, passing it the process identifier of the WebContent process."

Thanks for reviewing! I will update the patch.
Comment 5 Per Arne Vollan 2019-08-08 12:47:19 PDT
Created attachment 375832 [details]
Patch
Comment 6 WebKit Commit Bot 2019-08-08 13:32:48 PDT
Comment on attachment 375832 [details]
Patch

Clearing flags on attachment: 375832

Committed r248440: <https://trac.webkit.org/changeset/248440>