Bug 200543 – [Mac] Use the PID of the WebContent process when issuing local file read sandbox extensions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

When issuing local file read sandbox extensions, use the process identifier of the WebContent process.

[Per Arne Vollan]

rdar://problem/49394015

[Per Arne Vollan]

Created attachment 375829 [details]
Patch

[Brent Fulgham]

Comment on attachment 375829 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375829&action=review

Looks good.

> Source/WebKit/ChangeLog:9
> +        the WebContent process.

Maybe it would be better phrased as:

"Adopt SPI to issue a process-specific sandbox extension for local file read, passing it the process identifier of the WebContent process."

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 375829 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375829&action=review
> 
> Looks good.
> 
> > Source/WebKit/ChangeLog:9
> > +        the WebContent process.
> 
> Maybe it would be better phrased as:
> 
> "Adopt SPI to issue a process-specific sandbox extension for local file
> read, passing it the process identifier of the WebContent process."

Thanks for reviewing! I will update the patch.

[Per Arne Vollan]

Created attachment 375832 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 375832 [details]
Patch

Clearing flags on attachment: 375832

Committed r248440: <https://trac.webkit.org/changeset/248440>

[Per Arne Vollan]

Created attachment 376628 [details]
Patch

[Brent Fulgham]

Comment on attachment 376628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376628&action=review

I think the log message should be changed, but otherwise this looks good. R=me.

> Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:357
> +        WTFLogAlways("Could not create a '%s' sandbox extension", path.utf8().data());

Thislog message could leak potentially private user data to our logs. Could you change it to one of the LOG_DEBUG macros, or perhaps just remove the path from the log file? it should be enough to log that a file extension could not be generated.

[Per Arne Vollan]

Created attachment 376647 [details]
Patch

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #8)
> Comment on attachment 376628 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376628&action=review
> 
> I think the log message should be changed, but otherwise this looks good.
> R=me.
> 
> > Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:357
> > +        WTFLogAlways("Could not create a '%s' sandbox extension", path.utf8().data());
> 
> Thislog message could leak potentially private user data to our logs. Could
> you change it to one of the LOG_DEBUG macros, or perhaps just remove the
> path from the log file? it should be enough to log that a file extension
> could not be generated.

Done.

Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 376647 [details]
Patch

Clearing flags on attachment: 376647

Committed r248832: <https://trac.webkit.org/changeset/248832>