Bug 203693 - Refactor uses of StructureStubInfo 'thisGPR' to a union for thisGPR and prototypeGPR
Summary: Refactor uses of StructureStubInfo 'thisGPR' to a union for thisGPR and proto...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 202767
  Show dependency treegraph
 
Reported: 2019-10-31 13:19 PDT by Saam Barati
Modified: 2019-11-01 16:08 PDT (History)
14 users (show)

See Also:


Attachments
patch (7.78 KB, patch)
2019-10-31 15:23 PDT, Saam Barati
mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (7.79 KB, patch)
2019-10-31 15:45 PDT, Saam Barati
sbarati: commit-queue-
Details | Formatted Diff | Diff
patch for landing (7.79 KB, patch)
2019-11-01 10:45 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-10-31 13:19:59 PDT
...
Comment 1 Saam Barati 2019-10-31 15:23:37 PDT
Created attachment 382508 [details]
patch
Comment 2 Mark Lam 2019-10-31 15:26:16 PDT
Comment on attachment 382508 [details]
patch

r=me
Comment 3 Yusuke Suzuki 2019-10-31 15:27:26 PDT
r=me too.
Comment 4 Saam Barati 2019-10-31 15:44:03 PDT
Comment on attachment 382508 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382508&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        I'm going to be adding a third overload for this field in when making
> +        GetByVal inline caching part of StructureStubInfo. It's nicer to for
> +        each use case of this field to use it by the proper name.

will fix my grammar here
Comment 5 Saam Barati 2019-10-31 15:45:31 PDT
Created attachment 382512 [details]
patch for landing
Comment 6 WebKit Commit Bot 2019-10-31 16:28:35 PDT
Comment on attachment 382512 [details]
patch for landing

Rejecting attachment 382512 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 382512, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=382512&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=203693&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 382512 from bug 203693.
Fetching: https://bugs.webkit.org/attachment.cgi?id=382512
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/JavaScriptCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/JavaScriptCore/ChangeLog' is out of date
W: f82ed8988558dd43ce74c8f948960772bc8b551d and refs/remotes/origin/master differ, using rebase:
:040000 040000 e06719e00928207ae2c36bc5b6e6f36490faf557 cca23a7465956a33eb7813e95dd65142fe89dc36 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/JavaScriptCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/JavaScriptCore/ChangeLog' is out of date
W: f82ed8988558dd43ce74c8f948960772bc8b551d and refs/remotes/origin/master differ, using rebase:
:040000 040000 e06719e00928207ae2c36bc5b6e6f36490faf557 cca23a7465956a33eb7813e95dd65142fe89dc36 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   a5d593eee80..e4a4400a954  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 251888 = a5d593eee8055920956dc57f2edab7b5a3d7eda2
r251889 = e4a4400a954b3c07e7948ef869d88c22f29091a6
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13197188
Comment 7 Saam Barati 2019-11-01 10:45:41 PDT
Created attachment 382593 [details]
patch for landing
Comment 8 WebKit Commit Bot 2019-11-01 11:48:39 PDT
The commit-queue encountered the following flaky tests while processing attachment 382593 [details]:

imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2019-11-01 11:48:40 PDT
The commit-queue encountered the following flaky tests while processing attachment 382593 [details]:

The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2019-11-01 13:52:06 PDT
The commit-queue encountered the following flaky tests while processing attachment 382593 [details]:

requestidlecallback/requestidlecallback-document-gc.html bug 203745 (author: rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2019-11-01 13:52:13 PDT
The commit-queue encountered the following flaky tests while processing attachment 382593 [details]:

imported/w3c/web-platform-tests/content-security-policy/style-src/style-src-injected-stylesheet-blocked.sub.html bug 203757 (author: dbates@webkit.org)
The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2019-11-01 16:07:41 PDT
Comment on attachment 382593 [details]
patch for landing

Clearing flags on attachment: 382593

Committed r251951: <https://trac.webkit.org/changeset/251951>
Comment 13 WebKit Commit Bot 2019-11-01 16:07:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Radar WebKit Bug Importer 2019-11-01 16:08:20 PDT
<rdar://problem/56831736>