Bug 203693 – Refactor uses of StructureStubInfo 'thisGPR' to a union for thisGPR and prototypeGPR

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

Created attachment 382508 [details]
patch

[Mark Lam]

Comment on attachment 382508 [details]
patch

r=me

[Yusuke Suzuki]

r=me too.

[Saam Barati]

Comment on attachment 382508 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382508&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        I'm going to be adding a third overload for this field in when making
> +        GetByVal inline caching part of StructureStubInfo. It's nicer to for
> +        each use case of this field to use it by the proper name.

will fix my grammar here

[Saam Barati]

Created attachment 382512 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 382512 [details]
patch for landing

Rejecting attachment 382512 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 382512, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=382512&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=203693&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 382512 from bug 203693.
Fetching: https://bugs.webkit.org/attachment.cgi?id=382512
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/JavaScriptCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/JavaScriptCore/ChangeLog' is out of date
W: f82ed8988558dd43ce74c8f948960772bc8b551d and refs/remotes/origin/master differ, using rebase:
:040000 040000 e06719e00928207ae2c36bc5b6e6f36490faf557 cca23a7465956a33eb7813e95dd65142fe89dc36 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/JavaScriptCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/JavaScriptCore/ChangeLog' is out of date
W: f82ed8988558dd43ce74c8f948960772bc8b551d and refs/remotes/origin/master differ, using rebase:
:040000 040000 e06719e00928207ae2c36bc5b6e6f36490faf557 cca23a7465956a33eb7813e95dd65142fe89dc36 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   a5d593eee80..e4a4400a954  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 251888 = a5d593eee8055920956dc57f2edab7b5a3d7eda2
r251889 = e4a4400a954b3c07e7948ef869d88c22f29091a6
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13197188

[Saam Barati]

Created attachment 382593 [details]
patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 382593 [details]:

imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 382593 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 382593 [details]:

requestidlecallback/requestidlecallback-document-gc.html bug 203745 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 382593 [details]:

imported/w3c/web-platform-tests/content-security-policy/style-src/style-src-injected-stylesheet-blocked.sub.html bug 203757 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 382593 [details]
patch for landing

Clearing flags on attachment: 382593

Committed r251951: <https://trac.webkit.org/changeset/251951>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56831736>