This is an automatically generated bug from the commit-queue. fast/events/resize-subframe-in-rendering-update.html has been flaky on the commit-queue. fast/events/resize-subframe-in-rendering-update.html was authored by rniwa@webkit.org. https://trac.webkit.org/browser/trunk/LayoutTests/fast/events/resize-subframe-in-rendering-update.html The commit-queue just saw fast/events/resize-subframe-in-rendering-update.html flake (text diff) while processing attachment 381247 [details] on bug 203021. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6 The bots will update this with information from each new failure. If you believe this bug to be fixed or invalid, feel free to close. The bots will re-open if the flake re-occurs. If you would like to track this test fix with another bug, please close this bug as a duplicate. The bots will follow the duplicate chain when making future comments.
Created attachment 381269 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw fast/events/resize-subframe-in-rendering-update.html flake (text diff) while processing attachment 381307 [details] on bug 203153. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6
Created attachment 381316 [details] Archive of layout-test-results from webkit-cq-03
Created attachment 381322 [details] Fixes the test
Thanks for the review!
Committed r251294: <https://trac.webkit.org/changeset/251294>
<rdar://problem/56415948>
This substantially improved test stability, but it's still failing fairly frequently. https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r251317%20(11394)/fast/events/resize-subframe-in-rendering-update-pretty-diff.html
(In reply to Alexey Proskuryakov from comment #8) > This substantially improved test stability, but it's still failing fairly > frequently. > > https://build.webkit.org/results/ > Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r251317%20(11394)/fast/events/ > resize-subframe-in-rendering-update-pretty-diff.html Hm... I did --iterations 100 to make sure it doesn't flake but I guess that was just on my machine.
Alright, the following command can reproduce the flakiness even on macOS Mojave: ./Tools/Scripts/run-webkit-tests --debug LayoutTests/fast/events/resize-* --iterations 100 --no-show-results --exit-after-n-failures=1 -1 I think the fundamental problem is that there is no way to order requestAnimationFrame and setTimeout deterministically right now. We need to remove the assertion inside setTimeout for now.
Created attachment 381376 [details] Fix the test
Comment on attachment 381376 [details] Fix the test Clearing flags on attachment: 381376 Committed r251328: <https://trac.webkit.org/changeset/251328>
Re-opened since this is blocked by bug 203384