More work in progress. This should unlock the ability to asynchronously fetch pasted content from the clipboard as ClipboardItems, via the Clipboard API.
Created attachment 381222 [details] Patch
Comment on attachment 381222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381222&action=review > Source/WebCore/Modules/async-clipboard/Clipboard.cpp:112 > + if (itemInfo.changeCount != changeCountAtStart) { This change count check should really be happening in the UI process side but it's okay for now.
Comment on attachment 381222 [details] Patch Attachment 381222 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13144645 New failing tests: editing/async-clipboard/clipboard-interfaces.html
Created attachment 381233 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 381222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381222&action=review >> Source/WebCore/Modules/async-clipboard/Clipboard.cpp:112 >> + if (itemInfo.changeCount != changeCountAtStart) { > > This change count check should really be happening in the UI process side but it's okay for now. Indeed — I’m planning to implement UI-process-side changeCount checking in a subsequent patch. I’ll add a FIXME here for now.
Created attachment 381247 [details] For EWS
The commit-queue encountered the following flaky tests while processing attachment 381247 [details]: fast/events/resize-subframe-in-rendering-update.html bug 203140 (author: rniwa@webkit.org) The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 381247 [details]: imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com) inspector/console/webcore-logging.html bug 203118 (authors: drousso@apple.com and eric.carlson@apple.com) The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 381247 [details]: The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 381247 [details]: media/remote-control-command-seek.html bug 192381 (authors: eric.carlson@apple.com and graouts@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 381247 [details] For EWS Rejecting attachment 381247 [details] from commit-queue. New failing tests: fast/events/resize-subframe-in-rendering-update.html inspector/console/webcore-logging.html Full output: https://webkit-queues.webkit.org/results/13146169
Created attachment 381279 [details] Archive of layout-test-results from webkit-cq-01 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-highsierra Platform: Mac OS X 10.13.6
The CQ test failures (fast/events/resize-subframe-in-rendering-update.html and inspector/console/webcore-logging.html) are unrelated. Committed: https://trac.webkit.org/r251279.
<rdar://problem/56406019>
Comment on attachment 381247 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=381247&action=review > Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:38 > +#import <WebCore/LegacyNSPasteboardTypes.h> Seems like this is left over from before you did some refactoring and isn’t needed.
Comment on attachment 381247 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=381247&action=review >> Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:38 >> +#import <WebCore/LegacyNSPasteboardTypes.h> > > Seems like this is left over from before you did some refactoring and isn’t needed. Good catch! Removing it now.