Validate Patch step can fail due to various reasons, e.g.: Bug closed, patch being obsolete/r-. However, the summary automatically generated by Buildbot for ValidatePatch for all these cases is: 'Validate Patch (failure)'. This isn't very readable/informative, and this also shows up in status-bubble hover-over messages, which looks somewhat ugly. We should improve this summary.
Created attachment 379477 [details] Patch
Created attachment 379479 [details] Change in Status bubble pop-over message
Sample runs: Success: https://ews-build.webkit-uat.org/#/builders/17/builds/4075 Warnings: https://ews-build.webkit-uat.org/#/builders/17/builds/4084 Bug * is already closed: https://ews-build.webkit-uat.org/#/builders/17/builds/4079 Patch * is obsolete: https://ews-build.webkit-uat.org/#/builders/17/builds/4081
Even better, this can stop at "Bug was already closed when EWS attempted to process it." The rest just repeats the same in a less user friendly form. The messages are only useful when there are some preliminary results, but even then, we can say something like "EWS observed failures prior to that, but couldn't determine if those were regressions yet."
(In reply to Alexey Proskuryakov from comment #4) > Even better, this can stop at "Bug was already closed when EWS attempted to > process it." I thought about doing that, but didn't go ahead with that approach, since another change I would be making is to display steps from previous builds (if there are RETRIED BUILDS). > The messages are only useful when there are some preliminary results, but > even then, we can say something like "EWS observed failures prior to that, > but couldn't determine if those were regressions yet." ok, make sense. I will update the patch to stop at "Bug was already closed when EWS attempted to process it" message. I think it's still ok to improve the Buildbot summary strings, so I will keep this change as well.
Created attachment 379483 [details] Patch
Sample run: https://ews.webkit-uat.org/status-bubble/379139/
Comment on attachment 379483 [details] Patch Clearing flags on attachment: 379483 Committed r250318: <https://trac.webkit.org/changeset/250318>
All reviewed patches have been landed. Closing bug.
<rdar://problem/55677508>