Bug 195945 – [ews-build] Improve summary for PrintConfiguration step

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

The summary automatically generated by Buildbot for PrintConfiguration looks like: 'xcodebuild -sdk ...'. This isn't very readable/informative. We should improve this.

Buildbot doesn't seem to respect descriptionDone for steps.ShellSequence class. Reference: https://github.com/buildbot/buildbot/issues/4088

[Aakash Jain]

Created attachment 365155 [details]
Patch

[EWS Watchlist]

Attachment 365155 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:771:  [PrintConfiguration.getResultSummary] Instance of 'PrintConfiguration' has no 'results' member  [pylint/E1101] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Aakash Jain]

Created attachment 365157 [details]
Patch

[EWS Watchlist]

Attachment 365157 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:771:  [PrintConfiguration.getResultSummary] Instance of 'PrintConfiguration' has no 'results' member  [pylint/E1101] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Can you attach a screenshot for the new behavior? 'Printed configuration' is more readable than 'xcodebuild -sdk ...', but not informative at all. Would it make sense for the step summary should contain some of the configuration details perhaps?

[EWS Watchlist]

Comment on attachment 365157 [details]
Patch

Attachment 365157 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11566659

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html

[EWS Watchlist]

Created attachment 365175 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Aakash Jain]

Created attachment 365218 [details]
Patch

[EWS Watchlist]

Attachment 365218 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:767:  [PrintConfiguration.__init__] Instance of 'PrintConfiguration' has no 'addLogObserver' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:789:  [PrintConfiguration.getResultSummary] Instance of 'PrintConfiguration' has no 'results' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:800:  [PrintConfiguration.getResultSummary] Instance of 'PrintConfiguration' has no 'getProperty' member  [pylint/E1101] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Aakash Jain]

Created attachment 365221 [details]
Patch

[EWS Watchlist]

Attachment 365221 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:767:  [PrintConfiguration.__init__] Instance of 'PrintConfiguration' has no 'addLogObserver' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:795:  [PrintConfiguration.getResultSummary] Instance of 'PrintConfiguration' has no 'results' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:806:  [PrintConfiguration.getResultSummary] Instance of 'PrintConfiguration' has no 'getProperty' member  [pylint/E1101] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Aakash Jain]

Created attachment 365233 [details]
Screenshot with this fix

[Aakash Jain]

(In reply to Alexey Proskuryakov from comment #5)
> Can you attach a screenshot for the new behavior?
Attached.

> Would it make sense for the step summary should contain some of the configuration details perhaps?
Updated the patch to extract and print the configuration details.

Sample summary: OS: High Sierra (10.13.6), Xcode: 12.2

[Lucas Forschler]

Comment on attachment 365221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365221&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:774
> +            return 'Unkown'

typo

> Tools/BuildSlaveSupport/ews-build/steps.py:787
> +        }

do we need to go back this far?

[Aakash Jain]

> do we need to go back this far?
Not really, but I don't see any harm as well. External machines would be connecting to this EWS which might be running any old OS.

[Aakash Jain]

Committed r243177: <https://trac.webkit.org/changeset/243177>

[Radar WebKit Bug Importer]

<rdar://problem/49039926>