Bug 195945 - [ews-build] Improve summary for PrintConfiguration step
Summary: [ews-build] Improve summary for PrintConfiguration step
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-19 07:46 PDT by Aakash Jain
Modified: 2019-09-24 13:08 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2019-03-19 07:48 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (1.60 KB, patch)
2019-03-19 08:08 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.90 MB, application/zip)
2019-03-19 09:54 PDT, EWS Watchlist
no flags Details
Patch (3.30 KB, patch)
2019-03-19 13:13 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (3.45 KB, patch)
2019-03-19 13:39 PDT, Aakash Jain
lforschler: review+
Details | Formatted Diff | Diff
Screenshot with this fix (40.07 KB, image/png)
2019-03-19 14:57 PDT, Aakash Jain
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-03-19 07:46:41 PDT
The summary automatically generated by Buildbot for PrintConfiguration looks like: 'xcodebuild -sdk ...'. This isn't very readable/informative. We should improve this.

Buildbot doesn't seem to respect descriptionDone for steps.ShellSequence class. Reference: https://github.com/buildbot/buildbot/issues/4088
Comment 1 Aakash Jain 2019-03-19 07:48:33 PDT
Created attachment 365155 [details]
Patch
Comment 2 EWS Watchlist 2019-03-19 07:51:14 PDT Comment hidden (obsolete)
Comment 3 Aakash Jain 2019-03-19 08:08:29 PDT
Created attachment 365157 [details]
Patch
Comment 4 EWS Watchlist 2019-03-19 08:10:04 PDT Comment hidden (obsolete)
Comment 5 Alexey Proskuryakov 2019-03-19 09:13:37 PDT
Can you attach a screenshot for the new behavior? 'Printed configuration' is more readable than 'xcodebuild -sdk ...', but not informative at all. Would it make sense for the step summary should contain some of the configuration details perhaps?
Comment 6 EWS Watchlist 2019-03-19 09:54:31 PDT Comment hidden (obsolete)
Comment 7 EWS Watchlist 2019-03-19 09:54:33 PDT Comment hidden (obsolete)
Comment 8 Aakash Jain 2019-03-19 13:13:55 PDT
Created attachment 365218 [details]
Patch
Comment 9 EWS Watchlist 2019-03-19 13:17:45 PDT Comment hidden (obsolete)
Comment 10 Aakash Jain 2019-03-19 13:39:23 PDT
Created attachment 365221 [details]
Patch
Comment 11 EWS Watchlist 2019-03-19 13:41:50 PDT Comment hidden (obsolete)
Comment 12 Aakash Jain 2019-03-19 14:57:02 PDT
Created attachment 365233 [details]
Screenshot with this fix
Comment 13 Aakash Jain 2019-03-19 14:57:28 PDT
(In reply to Alexey Proskuryakov from comment #5)
> Can you attach a screenshot for the new behavior?
Attached.

> Would it make sense for the step summary should contain some of the configuration details perhaps?
Updated the patch to extract and print the configuration details.

Sample summary: OS: High Sierra (10.13.6), Xcode: 12.2
Comment 14 Lucas Forschler 2019-03-19 15:04:42 PDT
Comment on attachment 365221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365221&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:774
> +            return 'Unkown'

typo

> Tools/BuildSlaveSupport/ews-build/steps.py:787
> +        }

do we need to go back this far?
Comment 15 Aakash Jain 2019-03-19 15:38:51 PDT
> do we need to go back this far?
Not really, but I don't see any harm as well. External machines would be connecting to this EWS which might be running any old OS.
Comment 16 Aakash Jain 2019-03-19 16:02:28 PDT
Committed r243177: <https://trac.webkit.org/changeset/243177>
Comment 17 Radar WebKit Bug Importer 2019-03-19 16:03:34 PDT
<rdar://problem/49039926>