Bug 203261 - [ews] Status bubble should show previous failures if any in case patch is skipped
Summary: [ews] Status bubble should show previous failures if any in case patch is ski...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-22 11:49 PDT by Aakash Jain
Modified: 2019-10-22 13:49 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2019-10-22 11:52 PDT, Aakash Jain 		jbedard: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-10-22 11:49:33 PDT 
[ews] Status bubble should show previous failures if any in case patch is skipped. 

For e.g.: if a patch failed EWS, and someone lands/obsoletes the patch, and then click on 'Retry failed builds' button, status-bubble for would be white (skipped). However the status-bubble doesn't indicate that before being skipped, patch did encountered failures.

We should update the status-bubbble tool-tip for skipped patches so as to indicate the previous failures.
Comment 1 Aakash Jain 2019-10-22 11:52:40 PDT 
Created attachment 381576 [details]
Patch
Comment 2 Aakash Jain 2019-10-22 11:54:38 PDT 
Sample run:

Skipped build with previous failed build: https://ews.webkit-uat.org/status-bubble/381492/ (look at 'style' bubble)

Skipped build without previous failed build: https://ews.webkit-uat.org/status-bubble/381322/
Comment 3 Aakash Jain 2019-10-22 13:48:11 PDT 
Committed r251453: <https://trac.webkit.org/changeset/251453>
Comment 4 Radar WebKit Bug Importer 2019-10-22 13:49:15 PDT 
<rdar://problem/56514010>