Bug 202021 - [FTW, WinCairo] Support running tests in Release mode
Summary: [FTW, WinCairo] Support running tests in Release mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 161817
  Show dependency treegraph
 
Reported: 2019-09-19 19:40 PDT by Brent Fulgham
Modified: 2019-09-19 21:11 PDT (History)
14 users (show)

See Also:


Attachments
Patch (4.85 KB, patch)
2019-09-19 19:47 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-09-19 19:40:52 PDT
In Bug 201597, we added new features to better lock down JSC features in the potentially untrusted WebContent process.

Unfortunately, this change included XPC Dictionary items used at startup to lock down JSC features before entering the main execution of the process. These changes were not done for the WinCairo or FTW ports.

We need to pass the state of the JIT and whether to enable certain JSC features at process launch. Since the XPC mechanisms we use on macOS and iOS do not exist on Windows, I am implementing them as command-line flags.
Comment 1 Brent Fulgham 2019-09-19 19:47:28 PDT
Created attachment 379196 [details]
Patch
Comment 2 WebKit Commit Bot 2019-09-19 20:51:44 PDT
Comment on attachment 379196 [details]
Patch

Clearing flags on attachment: 379196

Committed r250119: <https://trac.webkit.org/changeset/250119>
Comment 3 WebKit Commit Bot 2019-09-19 20:51:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-09-19 20:52:19 PDT
<rdar://problem/55546547>